Feature: OTH-257 Refaktorera Hämtning av Parkeringsplatser flytta till leasing#319
Merged
lalmqvist merged 9 commits intoJul 2, 2025
Conversation
lalmqvist
force-pushed
the
feature/uth-257-refaktorera-hamtning-av-parkeringsplatser-flytta-till-leasing
branch
from
4f83e2b to
65c17f8
Compare
lalmqvist
changed the base branch from
feat/UTH-251-Model-Changes-to-Fetch-RentalObject-from-XPand-DB
to
main
momentiris
reviewed
Jul 1, 2025
Comment on lines
+32
to
+40
| includeRentalObjectCodes?: string[] | ||
| ): Promise<AdapterResult<RentalObject[], 'not-found' | 'unknown'>> => { | ||
| try { | ||
| let url = `${tenantsLeasesServiceUrl}/parking-spaces` | ||
|
|
||
| if (includeRentalObjectCodes && includeRentalObjectCodes.length) { | ||
| const codesParam = includeRentalObjectCodes.join(',') | ||
| url += `?includeRentalObjectCodes=${encodeURIComponent(codesParam)}` | ||
| } |
Contributor
There was a problem hiding this comment.
I think includeRentalObjectCodes feels like a name for a boolean.
I think rentalObjectCodes fits better for a list of strings :)
| * content: | ||
| * type: array | ||
| * items: | ||
| * $ref: '#/components/schemas/RentalObject' |
Contributor
There was a problem hiding this comment.
I'm a bit confused about this $ref usage. We use this in property-base and work-order projects and I don't think it's set up here in leasing (or in property-management for that matter). Do you know anything about this?
Contributor
Author
There was a problem hiding this comment.
Nope, good point. Both me and Johanna worked on this code so I can't answer this one. But it looks like it doesn't do anything so I'll see what I can do.
momentiris
approved these changes
Jul 2, 2025
lalmqvist
deleted the
feature/uth-257-refaktorera-hamtning-av-parkeringsplatser-flytta-till-leasing
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.