Repository navigation
Add marine snow filter control and telemetry messages - #316
Merged
Merged
Conversation
SetMarineSnowFilterCtrl and MarineSnowFilterTel carry a FilterMessage, like the color correction messages, so that the app can switch the marine snow filter of the X3 Ultra on and off and set its intensity. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
follesoe
added
enhancement
johannesschrimpf
approved these changes
Oct 5, 2026
Say what the filter does and what the intensity sets, in as many lines as the comments of the other filters. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
MarineSnowFilterFrames holds the past (1..4) and future (0..2) frames that the filter compares each frame with. Each future frame delays the video by 33 to 40 ms, so 0 future frames gives the lowest latency. SetMarineSnowFilterCtrl takes it as an optional field, so that an app that only sets the on/off and the intensity leaves the frames as they are, and MarineSnowFilterTel reports it. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds
SetMarineSnowFilterCtrlandMarineSnowFilterTel, each holding aFilterMessage, like the color correction messages of #263. The app uses them to switch the marine snow filter of the X3 Ultra (bedesnow, BluEye-Robotics/blunux-color-filters#8) on and off and to set its intensity. The drone side is BluEye-Robotics/p2_msgs#70, BluEye-Robotics/p2_drone#1154 and BluEye-Robotics/gst_rtsp_record#361.MarineSnowFilterFramessets the past (1..4) and future (0..2) frames that the filter compares each frame with. Each future frame delays the video by 33 to 40 ms, so 0 future frames gives the lowest latency. It is optional inSetMarineSnowFilterCtrl, so an app that only sets the on/off and the intensity leaves the frames as they are. At 4K30 in dense snow on the X3 Ultra, every combination keeps up except 4 past with 2 future (34 ms per frame).The comment of
SetMarineSnowFilterCtrlsays what the intensity does and that the app should switch the filter off during laser detection.protocandprotolintpass, and the protocol builds and installs in the Blunux 5.2 SDK.🤖 Generated with Claude Code