Repository navigation
feat(api): BA-116 reject malformed JSON with safe client 400 error response - #1042
Open
ranjeetprabhatedu-dotcom wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR implements BA-116 to reject malformed JSON request bodies with a safe, standardized HTTP 400 client error rather than allowing an unhandled 500 server error.
malformedJsonHandlermiddleware inapp.controller.tsand registers it inmain.tsto interceptSyntaxErrorwith status 400 from body parsing.{ statusCode: 400, message: 'Malformed JSON payload in request body', error: 'Bad Request' }).next(err)to preserve downstream error handling.app.controller.spec.tscovering both malformed JSON interception and regular error passthrough.BackendAcademy/src/main.tsBackendAcademy/src/app.controller.tsBackendAcademy/src/app.controller.spec.tsCloses #1029