Repository navigation
feat(social): bound challenge submission attempts (BA-057) - #1039
Open
ranjeetprabhatedu-dotcom wants to merge 1 commit into
Open
ranjeetprabhatedu-dotcom wants to merge 1 commit into
ranjeetprabhatedu-dotcom wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR addresses issue #970 (BA-057) by enforcing a bounded retry/attempt limit on challenge submissions with boundary test coverage before, at, and beyond the configured limit.
BackendAcademy/src/social/dto/challenge.dto.ts: Added optionalmaxAttempts?: numberconfiguration toCreateChallengeDtowith@IsOptional(),@IsInt(), and@Min(1).BackendAcademy/src/social/challenge.service.ts: Enforce attempt tracking and retry limits per user per challenge (defaulting to 3 attempts), rejecting excessive submissions withBadRequestException.BackendAcademy/src/social/challenge.service.spec.ts: Added comprehensive unit tests asserting behavior before the limit, at the limit, beyond the limit, custom configured limits, and input validation.challenge.service.spec.tspass cleanly (100% Green).Closes #970