Creating this PR with commits needed for Pixel 2 XL (taimen)#1
Open
nitin1438 wants to merge 3 commits into
Open
Creating this PR with commits needed for Pixel 2 XL (taimen)#1nitin1438 wants to merge 3 commits into
nitin1438 wants to merge 3 commits into
Conversation
It doesn't make sense to show both if they are just differing in letter case. For example, Indian carrier Jio shows "JIO - Jio". Avoid this by using case insensitive comparison. Change-Id: Iea5d4ebb1f16dc794e896b38ecbf6b24ff2221e5 Signed-off-by: chrisl7 <wandersonrodriguesf1@gmail.com>
This fixes 4g+ indication on some carriers (such as Vi India with band 8+3 CA). While we're at it, remove the total bandwidth threshold check, as it's unnecessary - for example, 10+10 MHz is still carrier aggregation. Change-Id: I940e56bae334024a7c5588e509f94ab484ee4e10 Signed-off-by: chrisl7 <wandersonrodriguesf1@gmail.com>
…nt, int)'. (#8) The MediaTek IMS package for Android Q, at the very least (likely for the rest, too) invoke this method in their `sendSms` method; Google, in their infinite wisdom, decided that this method needed a message ID passed in as well, changing the signature to 'public void TelephonyMetrics.writeRilSendSms(int, int, int, int, long)' and resulting in a MethodNotFoundException being raised in com.mediatek.ims, crashing it. Fixes phhusson/treble_experimentations#2125. Co-authored-by: Sarah Vandomelen <sarah@sightworks.com> Change-Id: I1d4c2816fb8891cf5b75058bfe5f1eea960e901b
blissgerrit
force-pushed
the
typhoon
branch
2 times, most recently
from
fae7a87 to
5b9cdec
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Please review and merge.
Regards,
Nitin