Skip to content

fix(bkjsclient): overwrite asset.canDownload coming from bkjsclient based on the local user profile - #2317

Merged
Tweekazoid merged 1 commit into
BlenderKit:mainfrom
agajdosi:2316
Oct 6, 2026
Merged

Tweekazoid merged 1 commit into
BlenderKit:mainfrom
agajdosi:2316

Conversation

@agajdosi

@agajdosi agajdosi commented Sep 25, 2026 •

Copy link
Copy Markdown
Member

Sets the asset.canDownload based on the locally logged in user as this user's api key will decide whether the download will fail or not.

@agajdosi
agajdosi marked this pull request as draft September 25, 2026 12:13
@codecov

codecov Bot commented Sep 25, 2026 •

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 10.00000% with 9 lines in your changes missing coverage. Please review.
✅ Project coverage is 34.17%. Comparing base (32644f9) to head (adeb5b9).

Files with missing lines Patch % Lines
utils.py 16.66% 5 Missing ⚠️
asset_bar/asset_bar_op.py 0.00% 4 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #2317      +/-   ##
==========================================
- Coverage   34.18%   34.17%   -0.01%     
==========================================
  Files          87       87              
  Lines       27607    27617      +10     
==========================================
+ Hits         9438     9439       +1     
- Misses      18169    18178       +9     
Flag Coverage Δ
python 34.17% <10.00%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
asset_bar/asset_bar_op.py 16.57% <0.00%> (-0.03%) ⬇️
utils.py 28.60% <16.66%> (-0.06%) ⬇️
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Comment thread asset_bar/asset_bar_op.py Outdated
@agajdosi agajdosi changed the title fix(bkjsclient): if user is logged-in overwrite canDownload=False coming from bkjsclient WIP fix(bkjsclient): if user is logged-in overwrite canDownload=False coming from bkjsclient Oct 5, 2026
@agajdosi agajdosi changed the title WIP fix(bkjsclient): if user is logged-in overwrite canDownload=False coming from bkjsclient fix(bkjsclient): overwrite asset.canDownload coming from bkjsclient based on the local user profile Oct 6, 2026
@agajdosi
agajdosi marked this pull request as ready for review October 6, 2026 12:39
@agajdosi
agajdosi requested a review from Tweekazoid October 6, 2026 12:51
@Tweekazoid
Tweekazoid merged commit 998d232 into BlenderKit:main Oct 6, 2026
29 of 31 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Send to Blender uses canDownload information based on web login, but download uses local profile data

2 participants