Skip to content

Remove MacOS CI#108

Merged
Kaydax merged 4 commits into
masterfrom
mac-ci-fix
Dec 13, 2025
Merged

Remove MacOS CI#108
Kaydax merged 4 commits into
masterfrom
mac-ci-fix

Conversation

@Kaydax

@Kaydax Kaydax commented Sep 18, 2025

Copy link
Copy Markdown
Member

Has CMake issues, and we don't natively support metal, meaning use of MoltenVK, which doesn't support Geometry Shaders due to Apple Silicon not supporting them.

@Kaydax Kaydax requested a review from arduano September 18, 2025 03:12

@arduano arduano left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lol

Copilot AI review requested due to automatic review settings December 13, 2025 02:59
@Kaydax Kaydax changed the title Fix OSX CI Remove MacOS CI Dec 13, 2025

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR attempts to fix macOS CI build failures by setting a CMake-related environment variable before building the Rust binary. The project uses CMake indirectly through the shaderc-sys Rust crate dependency, which requires CMake for compilation.

Key Changes:

  • Adds a new workflow step to set the CMAKE_POLICY_MINIMUM_VERSION environment variable to "3.5" in the macOS build job

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread .github/workflows/build.yml Outdated
Comment thread .github/workflows/build.yml Outdated
@Kaydax Kaydax requested a review from arduano December 13, 2025 03:03

@arduano arduano left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@Kaydax Kaydax merged commit 6e3fc29 into master Dec 13, 2025
1 check passed
@Kaydax Kaydax deleted the mac-ci-fix branch December 13, 2025 21:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants