Skip to content

Clean markup and heading level attribute#28

Open
firestar300 wants to merge 5 commits into
developfrom
feature/clean-markup
Open

Clean markup and heading level attribute#28
firestar300 wants to merge 5 commits into
developfrom
feature/clean-markup

Conversation

@firestar300

@firestar300 firestar300 commented Jun 26, 2026

Copy link
Copy Markdown
Contributor

Clean markup and heading level attribute


Note

Medium Risk
Front-end markup and accordion selectors change, which can break custom CSS or JS; mitigated by deprecated saves, dual accordion init, and legacy styles.

Overview
Refactors FAQ block saved HTML to rely on standard wp-block-blockparty-faq-* classes instead of custom faq__* wrappers, and wires the front-end accordion to the new trigger/panel selectors (with PHP-localized config updated to match).

Adds a headingLevel (h2–h6) setting on the parent FAQ block (inspector toggle group when accordion mode is on), propagated via block context and synced onto each question so accordion questions render as the chosen heading with a proper <button class="wp-block-blockparty-faq-trigger">.

Backward compatibility: deprecated save definitions preserve prior 2.0.x markup (faq__panel, faq__trigger, etc.), script.js initializes accordions for both new and legacy selectors, and styles include a legacy section so existing content keeps working.

Translations and POT are regenerated for per-block build entry points; package version bumps to 2.0.3.

Reviewed by Cursor Bugbot for commit 4a0bdae. Bugbot is set up for automated code reviews on this repo. Configure here.

Replace faq__* classes with wp-block-blockparty-faq-* structure, add CSS custom properties, and register deprecated handlers so existing 2.0.x content keeps validating and rendering.
Mirror blockparty-accordion behavior: parent-level control synced to child questions, shown only when accordion mode is enabled.

@cursor cursor Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cursor Bugbot has reviewed your changes and found 1 potential issue.

Fix All in Cursor

❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.

Reviewed by Cursor Bugbot for commit 1343b64. Configure here.

Comment thread src/faq-item/edit.js
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant