Clean markup and heading level attribute#28
Open
firestar300 wants to merge 5 commits into
Open
Conversation
Replace faq__* classes with wp-block-blockparty-faq-* structure, add CSS custom properties, and register deprecated handlers so existing 2.0.x content keeps validating and rendering.
Mirror blockparty-accordion behavior: parent-level control synced to child questions, shown only when accordion mode is enabled.
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.
Reviewed by Cursor Bugbot for commit 1343b64. Configure here.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Clean markup and heading level attribute
Note
Medium Risk
Front-end markup and accordion selectors change, which can break custom CSS or JS; mitigated by deprecated saves, dual accordion init, and legacy styles.
Overview
Refactors FAQ block saved HTML to rely on standard
wp-block-blockparty-faq-*classes instead of customfaq__*wrappers, and wires the front-end accordion to the new trigger/panel selectors (with PHP-localized config updated to match).Adds a
headingLevel(h2–h6) setting on the parent FAQ block (inspector toggle group when accordion mode is on), propagated via block context and synced onto each question so accordion questions render as the chosen heading with a proper<button class="wp-block-blockparty-faq-trigger">.Backward compatibility: deprecated
savedefinitions preserve prior 2.0.x markup (faq__panel,faq__trigger, etc.),script.jsinitializes accordions for both new and legacy selectors, and styles include a legacy section so existing content keeps working.Translations and POT are regenerated for per-block build entry points; package version bumps to 2.0.3.
Reviewed by Cursor Bugbot for commit 4a0bdae. Bugbot is set up for automated code reviews on this repo. Configure here.