Blockparty icons#185
Open
firestar300 wants to merge 5 commits into
Open
Conversation
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 3 potential issues.
❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.
Reviewed by Cursor Bugbot for commit 6294656. Configure here.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

webpack-sprite-hash-plugin.jspour invalider le cache des sprites SVGNote
Medium Risk
Editor icon collections and the Composer plugin swap can break the block editor if APIs or install paths differ; ignoring composer.lock makes installs less reproducible across environments.
Overview
Replaces the
beapi/icon-blockComposer dependency withbeapi/blockparty-iconsand updatesEditoricon registration to the Blockparty API: theme sprites (icon-sprite,icon-social) register as sprite collections with aversionfrom content hashes, and the media-library collection id becomesmedia.Adds
webpack-sprite-hash-plugin, which writesdist/sprite-hashes.asset.phpafter build;Svg::get_sprite_hash()reads it so sprite URLs can invalidate browser cache when SVGs change.Composer / tooling:
composer.lockis gitignored and the tracked lockfile is removed; Psalm is dropped fromcomposer.json,grumphp.yml, andpsalm.xml. Text domains move frombeapi-frontend-frameworktobeapi-blocks-theme, and theme-specificbeapi-iconblock SCSS is removed.Reviewed by Cursor Bugbot for commit 054f080. Bugbot is set up for automated code reviews on this repo. Configure here.