Skip to content

Blockparty icons#185

Open
firestar300 wants to merge 5 commits into
mainfrom
feature/blockparty-icons
Open

Blockparty icons#185
firestar300 wants to merge 5 commits into
mainfrom
feature/blockparty-icons

Conversation

@firestar300

@firestar300 firestar300 commented Jun 25, 2026

Copy link
Copy Markdown
Contributor
  • Suppression de psalm
  • Untrack de composer.lock
  • Remplacement de l'appel au plugin beapi-icon-block par blockparty-icons
  • Ajout du plugin Webpack webpack-sprite-hash-plugin.js pour invalider le cache des sprites SVG
  • Fix des text domain (reliquat text-domain du bff)

Note

Medium Risk
Editor icon collections and the Composer plugin swap can break the block editor if APIs or install paths differ; ignoring composer.lock makes installs less reproducible across environments.

Overview
Replaces the beapi/icon-block Composer dependency with beapi/blockparty-icons and updates Editor icon registration to the Blockparty API: theme sprites (icon-sprite, icon-social) register as sprite collections with a version from content hashes, and the media-library collection id becomes media.

Adds webpack-sprite-hash-plugin, which writes dist/sprite-hashes.asset.php after build; Svg::get_sprite_hash() reads it so sprite URLs can invalidate browser cache when SVGs change.

Composer / tooling: composer.lock is gitignored and the tracked lockfile is removed; Psalm is dropped from composer.json, grumphp.yml, and psalm.xml. Text domains move from beapi-frontend-framework to beapi-blocks-theme, and theme-specific beapi-icon block SCSS is removed.

Reviewed by Cursor Bugbot for commit 054f080. Bugbot is set up for automated code reviews on this repo. Configure here.

@cursor cursor Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cursor Bugbot has reviewed your changes and found 3 potential issues.

Fix All in Cursor

❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.

Reviewed by Cursor Bugbot for commit 6294656. Configure here.

Comment thread inc/Services/Editor.php Outdated
Comment thread inc/Services/Editor.php
Comment thread inc/Services/Editor.php
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant