feat(app): add Meta glasses capture integration#9310
Conversation
|
Thanks for carving the Meta glasses runtime work out of the larger branch. This is directionally interesting and the scope is more coherent than the earlier mixed PR, but I do not think this is ready for maintainer approval/merge yet. Blocking / needs human maintainer review:
I’ve labeled this for maintainer/security/dependency/workflow review plus tests. I’m intentionally not asking to split this only because it is large—the feature is cohesive—but the privacy defaults, vendored dependency surface, lockfile churn, and unrelated conversation parser changes should be addressed or explicitly accepted by maintainers before this moves out of draft. |
|
Addressed review blockers in b1c34d3. Changes:
Local checks:
|
|
Thanks for putting this together — the Meta glasses capture flow is a coherent product surface and the direction looks potentially valuable for Omi. I’m not approving this draft, and I think it needs human maintainer review before merge because it is a large device/privacy integration with a vendored native plugin, background camera/BLE streaming, wake-lock/foreground-service behavior, permission handling, and a new photo-ingestion path. A few things I’d want validated before this is considered merge-ready:
I did not see an obvious malicious/supply-chain attack in the static review, but the size and native/device surfaces mean this should stay under |
Theory
Meta glasses capture failed because the app lacked a checked-in DAT bridge plus app-level registration, queue, watchdog, and capture-cache contracts. #9084 mixed that with docs/examples/auth/device-list work, so this PR keeps only the runtime path.
Scope
Cut from #9084
Tests
flutter test test/unit/meta_glasses_relay_queue_test.dartfailed before DAT/runtime files existed.Notes
app/lib/pages/home/page.dart.