fix(app): treat in-progress conversation 404 as benign#9260
Draft
Git-on-my-level wants to merge 1 commit into
Draft
fix(app): treat in-progress conversation 404 as benign#9260Git-on-my-level wants to merge 1 commit into
Git-on-my-level wants to merge 1 commit into
Conversation
When WebSocket auto-finalize races POST /v1/conversations, HTTP 404 means the in-progress pointer is already gone — return null instead of reporting to Crashlytics. Extract interpretProcessInProgressConversationResponse for hermetic tests and document the E2E verification path. Verification: cd app && fvm flutter test test/backend/process_in_progress_conversation_test.dart (3 passed) Closes #9241 Co-authored-by: Cursor <cursoragent@cursor.com>
![cubic-dev-ai[bot]](https://avatars.githubusercontent.com/in/1082092?s=60&v=4){kind=small}
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Merge order & dependencies
Summary
processInProgressConversationas expectednullwhen WS auto-finalize races the client.Related: #8749
Test plan
Merge with a regular merge (no squash).
Closes #9241
Made with Cursor