feat: synchro and publish BAL mes-adresses#130
Merged
fufeck merged 13 commits intoMay 13, 2026
Conversation
MaGOs92
approved these changes
May 12, 2026
MaGOs92
left a comment
MaGOs92
left a comment
Collaborator
There was a problem hiding this comment.
Code LGTM, j'ajouterais un petit loader quand on clique sur OK dans la modale de confirmation. L'opération prend un peu de temps donc on peut penser que ça bug.
| isDemo: boolean = false, | ||
| ): Promise<Client> { | ||
| const response = await fetch( | ||
| `${getProxyURL(isDemo)}/revisions/${revisionId}/sync-ids-ban-publish`, |
Collaborator
There was a problem hiding this comment.
Pas besoin du proxy getProxyURL, api-depot-demo ne publie pas dans la BAN.
Collaborator
|
Aussi à mon avis il faudrait masquer / griser le bouton de synchro quand il ne sert à rien ou risque de causer des soucis. Par exemple sur les bal en démo / brouillon ou quand la commune est sur l'ancien socle |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
CONTEXT
PR