feat: add alerts in data-gouv export#50
Merged
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR extends the weekly Data.gouv CSV export to include alert (“alertes”) counts per commune alongside existing signalement counts, and updates the task test accordingly.
Changes:
- Add
AlertService.getAlertCountsByCommune()to compute alert status totals grouped by commune. - Update
TaskService.weeklyDataGouvCSVExport()to merge signalement + alert counts per commune and export the expanded CSV schema. - Extend the Task module test to create alerts and assert the new CSV columns/rows (including communes that only appear via alerts).
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
src/tests/task.spec.ts |
Updates the weekly Data.gouv export test to seed alerts and validate the new alert count columns and an additional commune row. |
src/modules/task/task.service.ts |
Merges signalement + alert counts per commune, updates CSV header/rows, and sorts by combined totals before upload. |
src/modules/task/task.module.ts |
Imports AlertModule so TaskService can inject AlertService. |
src/modules/alert/alert.service.ts |
Adds a query-based aggregation method to return alert counts by commune and status. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.