feat: disable proconnect connexion for communes#49
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR prevents ProConnect authentication for organizations identified as communes (mairies), and surfaces a structured error to the frontend including a link to Mes Adresses.
Changes:
- Extend INSEE org lookup to detect communes (legal category
7210) and returncodeCommune. - Block ProConnect callback for communes with a
FORBIDDENerror that includes a Mes Adresses redirect link. - Update controller redirect logic and integration tests to accommodate new error shapes/messages.
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 3 comments.
| File | Description |
|---|---|
src/tests/proconnect.spec.ts |
Updates existing integration tests and adds coverage for commune rejection (with Mes Adresses link). |
src/modules/proconnect/proconnect.service.ts |
Adds commune blocking logic and switches some errors to structured HttpException payloads. |
src/modules/proconnect/proconnect.controller.ts |
Redirects FORBIDDEN errors to frontend with error/errorLink query params. |
src/modules/proconnect/insee.service.ts |
Adds isCommune + codeCommune inference from INSEE response. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.