docs(memory-providers): fix Mnemosyne tool count, install symlink, and lifecycle phrasing#15
Open
AxDSan wants to merge 1 commit into
Conversation
Four verified corrections from source: 1. Tool count: 19 -> 26 (7 tools were missing: mnemosyne_remember_canonical, mnemosyne_recall_canonical, mnemosyne_shared_remember, mnemosyne_shared_recall, mnemosyne_shared_forget, mnemosyne_shared_stats, mnemosyne_triple_end) 2. Install symlink: was pointing at mnemosyne/ (no register_memory_provider) now points at hermes_memory_provider/ (where the entry point lives) 3. Removed ✓ Memory provider: built-in only Saved to config.yaml from setup snippet; zero-config path is just setting memory.provider in config.yaml 4. Lifecycle: register -> register_memory_provider for the provider contract, clarified register(ctx) is separate CLI command registration
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up review of NousResearch#34356. Four verified corrections sourced from the actual Mnemosyne codebase:
Tool count: 19 -> 26 — missed 7 tools:
mnemosyne_remember_canonical,mnemosyne_recall_canonical,mnemosyne_shared_remember,mnemosyne_shared_recall,mnemosyne_shared_forget,mnemosyne_shared_stats,mnemosyne_triple_end. Verified fromALL_TOOL_SCHEMASinhermes_memory_provider/__init__.py.Install symlink was broken (blocker) — the original docs symlink into
mnemosyne/package's__init__.py, which does NOT containregister_memory_provider(). That entry point lives in the sibling packagehermes_memory_provider/. A user following the original instructions would get "No memory provider plugins detected."Removed
hermes memory setupfrom install snippet — Mnemosyne is zero-config after settingmemory.provider: mnemosyne. No interactive wizard needed.Lifecycle phrasing —
registeris the CLI plugin entry point, not the provider contract method. The provider contract usesregister_memory_provider. Clarified both.Verification
Every claim confirmed against the live source (mnemosyne-memory, commit cf297d8):