Conversation
|
|
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Extend the production environment-expansion policy so an explicitly set
NAMEkeeps its current behavior, while an unsetNAMEfalls back to reading the UTF-8 file named byNAME_FILE; if neither variable is available, retain the existing missing-variable failure. Apply that policy through every existing expandable-field deserializer inzerofs/src/config.rs, while updating the locked-memory expansion path inzerofs/src/secrets.rsso the encryption password is read and assembled without introducing an ordinary plaintext password copy. Treat the credential as a single textual value, removing terminal line endings as the issue'scatworkaround does, and return contextual path/read/UTF-8 errors without including secret contents. ZeroFS configuration currently expands secret values only from process environment variables, while systemd credentials expose decrypted values as files beneath the credentials directory. Operators must therefore add a shell wrapper that reads each credential file and exports its contents before starting ZeroFS. The requested change should let the existing$NAMEand${NAME}configuration references consume file-backed credentials without executing shell expressions or adding provider-specific configuration keys. The issue is open and unassigned, its thread contains no active claim, and the supplied timeline and competing-PR data show no prior or in-flight implementation. With onlyZEROFS_PASSWORD_FILE,AWS_ACCESS_KEY_ID_FILE, andAWS_SECRET_ACCESS_KEY_FILEset to readable credential files, load a config that references the corresponding unsuffixed variables and verify the encryption password and AWS values contain the file contents rather than the paths; With bothNAMEandNAME_FILEset, verify the direct environment value wins so existing deployments do not change behavior; also verify ordinary expandable fields continue to support$VAR,${VAR}, defaults, and$$escaping.Fixes #559