Convert to Class Library#74
Merged
Merged
Conversation
Converts the BanjoBotAssets project to a Class Library, and adds a BanjoBotAssets.Console project to replicate the old behaviour. Moves appsettings.json to the Console project to preserve preferences
Also replaces defunct FortniteCentral URLs with equivelant fortniteapi.com URLs Additionally, this will require a PR in CUE4Parse-FortniteTypes to be merged (reimplements a helper method we had in our fork of CUE4Parse) BanjoByTheBay/CUE4Parse-FortniteTypes#2
Adds IExportStageReporter and IExportProgressReporter. When implementations are injected as services, AssetExportService will use them to report the current ExportStage (a new enum introduced to correlate with each step of AssetExportService.RunAsync), and any ExportProgress objects emitted by exporters. ExportProgress also has an optional (could become required) string to represent the type of exporter the progress object is coming from. Currently this is only used in UObjectExporter and BlueprintExporter. (Not GroupExporter, since TBH that should've been deprecated months ago in favour of UObjectExporter) Added example implementations of both reporters in BanjoBotAssets.Console
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Converts the main BanjoBotAssets project to a Class Library, and adds BanjoBotAssets.Console to act as a substitution for previous functionality.
As a bonus, updates CUE4Parse and fixes compatability issues.
(will require updating CUE4Parse-FortniteTypes based on this PR)