VAPI-2990 Add connectStatus fields to ReadyMetadata#12
Closed
smoghe-bw wants to merge 1 commit into
Closed
Conversation
Add ConnectStatus enum and extend ReadyMetadata with optional connect status fields (connectStatus, accountId, sessionId, from/to with type and tags) so callers can react to Connect verb outcomes. Remove the unused "established" event handler. Mirrors javascript-brtc-sdk PR #5. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
✅ Snyk checks have passed. No issues have been found so far.
💻 Catch issues earlier using the plugins for VS Code, JetBrains IDEs, Visual Studio, and Eclipse. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
ConnectStatusenum (INITIATED,COMPLETED,TIMED_OUT,DENIED,CANCELED,FAILED) matching the gateway's connect status valuesReadyMetadatawith optional connect status fields:connectStatus,accountId,sessionId,from,fromType,fromTags,to,toType,toTagsestablishedevent handler — connect status info is delivered via the existingreadyeventTest plan
testReadyEventWithConnectStatusFields— verifies all connect status fields decode from a ready eventtestReadyEventWithoutConnectStatusFieldsStillWorks— backward compatibility when gateway sends no connect statustestEstablishedEventHandlerNotRegistered— confirms established handler is removedtestEventHandlersRegisteredOnConnect— asserts established is no longer registered🤖 Generated with Claude Code