VAPI-2990 Add connect status callbacks for Connect verb#11
Closed
smoghe-bw wants to merge 1 commit into
Closed
Conversation
Surface connectStatus events from the gateway so SDK consumers can react to the terminal outcome of a <Connect> verb (completed, timed out, denied, canceled, failed). Extends ReadyMetadata with connect status fields and adds a dedicated onConnectStatus callback. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
✅ Snyk checks have passed. No issues have been found so far.
💻 Catch issues earlier using the plugins for VS Code, JetBrains IDEs, Visual Studio, and Eclipse. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
ConnectStatusenum with six terminal outcomes:initiated,completed,timedOut,denied,canceled,failedReadyMetadatawith optional connect status fields (connectStatus,accountId,sessionId,from/fromType/fromTags,to/toType/toTags)onConnectStatuscallback toBandwidthRTCClientthat fires when the gateway sends aconnectStatuseventestablishedevent handler (matches JS SDK PR #5)Test plan
testConnectStatusEventFiresOnConnectStatusCallback— verifies all connect status fields decode and fire callbacktestReadyEventWithConnectStatusFields— verifies ready events with connect status data decode correctlytestConnectStatusEventWithEmptyData— verifies graceful handling of empty datatestConnectStatusEventRegistered— verifies connectStatus handler is registered on connecttestEstablishedEventNoLongerRegistered— verifies established handler is removed🤖 Generated with Claude Code