docs: update contributing.md, fix spelling mistakes, upgrade to Python 3.14#777
Conversation
dormieriancitizen
left a comment
dormieriancitizen
left a comment
There was a problem hiding this comment.
Generally good changes, just a couple concerns about .env files
|
|
||
| Before running any command, you must be in the poetry virtualenv, with the following | ||
| environment variables exported: | ||
| Before running any command, make sure your `.env` file is configured with the following |
There was a problem hiding this comment.
This isn't how .env files work; they need something to load them
There was a problem hiding this comment.
o ya i forgot to add that i aint that much experienced using env.. i generally dont make any of my projects opensource or give it to anyone
This comment was marked as duplicate.
This comment was marked as duplicate.
Sorry, something went wrong.
dormieriancitizen
left a comment
dormieriancitizen
left a comment
There was a problem hiding this comment.
Again mostly good, just want to remove the .env stuff since nothing is going to load it (uv can do it but it doesn't do it automatically)
Co-authored-by: dormieriancitizen <111535275+dormieriancitizen@users.noreply.github.com>
Co-authored-by: dormieriancitizen <111535275+dormieriancitizen@users.noreply.github.com>
Co-authored-by: dormieriancitizen <111535275+dormieriancitizen@users.noreply.github.com>
Co-authored-by: dormieriancitizen <111535275+dormieriancitizen@users.noreply.github.com>
Co-authored-by: dormieriancitizen <111535275+dormieriancitizen@users.noreply.github.com>
|
@dormieriancitizen i aint that good in github as i just started doing PR yesterday, i clicked on apply suggestion. and i think it fixed the stuff which u gave? |
2 participants
…n 3.14
Description of the changes
Fixed spelling mistake of Occur, i upgraded to 3.14, i improved the contributing.md
i haven't tested this locally as this is just textual changes.