Skip to content

[image gen] allow overlays onto cards while drawing#773

Open
tobyers wants to merge 3 commits into
Ballsdex-Team:v3from
tobyers:v3
Open

[image gen] allow overlays onto cards while drawing#773
tobyers wants to merge 3 commits into
Ballsdex-Team:v3from
tobyers:v3

Conversation

@tobyers

@tobyers tobyers commented Jun 3, 2026

Copy link
Copy Markdown

Description of the changes

I've updated the image_gen.py functionality so it allows for overlays onto the collector_card section of the image, this allows for cooler, 3D designs which can include different light effects, filters, or other overlayed features.

image image

Were the changes in this PR tested?

  • Yes
  • No

To test:

  • See if all variables are set correctly
  • Not all the variables are required for the base bot
  • Test to see if images are drawn at correct size
  • Check that regular non-overlayed images still function normally

tobyers added 3 commits June 4, 2026 07:06
added the ability to create overlays
Allows for overlays on the MonsterDex Discord bot instance -- some changes will have to be made to allow integration with the base bot, but concept is same
@flaree

flaree commented Jun 4, 2026

Copy link
Copy Markdown
Member

This drastically changes the defaults of the generator, it should be done in a way that if there's no changes then someone wouldn't notice. also it saves back to PNG which you shouldn't due - keep it as WEBPAGE due to its compression

@dormieriancitizen

Copy link
Copy Markdown
Member

Perhaps I'm biased, but I would prefer #740 and then these sorts of changes (which are cool) could be easily be implemented by a renderer in a third party package

@tobyers

tobyers commented Jun 4, 2026

Copy link
Copy Markdown
Author

This drastically changes the defaults of the generator, it should be done in a way that if there's no changes then someone wouldn't notice. also it saves back to PNG which you shouldn't due - keep it as WEBPAGE due to its compression

I didn’t realise how many things actually changed from the base bot - I built this feature for the MonsterDex bot which already had some changes from the original BallsDex image generator code, it’s really only 1 block that would need changing. I’ll look over and compare this to the original image_gen.py code and attempt to make a more coherent version 👍

@tobyers

tobyers commented Jun 4, 2026

Copy link
Copy Markdown
Author

Perhaps I'm biased, but I would prefer #740 and then these sorts of changes (which are cool) could be easily be implemented by a renderer in a third party package

It’s really not a massive change, I think I made it seem like more than it is accidentally lmao

I plan on revising the code and re-releasing a better version to be more easily compatible

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants