Media management

[dormieriancitizen]

Description of the changes

Basics of the media management asked for—this PR is just the unused files, not conversion yet.

It's a draft because I hate the way boolean_input works—I'm pretty sure it blocks, default doesn't work, etc etc. Literally anything else would be better but I'm not sure what that anything else is (in the past I've used asyncclick but I didn't want to add another dependency). Also, it's kind of slow, even for small DBs, and I'm not quite sure why (it could be overhead from docker exec).

Were the changes in this PR tested?

Yes

[dormieriancitizen]

OK, I'm much more happy with how this looks now. I've used ffmpeg instead of imagemagick like the issue suggested, since I'm more familiar with it, but it seems to work equally well.

I've tested the changes with a mix of PNGs, JPEGs, and gifs, and they all seem to convert properly, though it would be good to check on more things.

If there are any usability changes for the commands you think would be good, I'm happy to implement them.

[laggron42]

So far I checked the conversion media tool, works good! Lot of nitpicks regarding style but most of that is just applying suggestions in raw.

I would also appreciate having a flag for changing the output format like avif

[dormieriancitizen]

Pre-commit is failing because of a line

  /home/runner/work/BallsDex-DiscordBot/BallsDex-DiscordBot/admin_panel/bd_models/models.py:260:29 - error: Expected 0 positional arguments (reportCallIssue)

I don't think I changed anything there, so I'm not sure why checks are failing. I've added the target format argument and it seems to work.

[laggron42]

It's also failing on master and I'm not sure why. You don't have to worry about it, I'll look into it

[dormieriancitizen]

I was using this on my own dex and I fixed a couple little things that annoyed me

[dormieriancitizen]

Realizing now that conversion probably won't work on pure windows (WSL / docker should be fine) because the shell won't be the same. I don't have a windows device to test on so not sure if that's actually true or just a incorrect assumption.

[dormieriancitizen]

Ok, made the changes suggested on discord.

• Ffmpeg output to tmp dir and then copy into the media folder so junk doesn't get produced on error
• Skip non-image formats (right now the list of image formats is hard coded, but let me know if you can think of a better way to do it)

[dormieriancitizen]

Changed base branch to v3, is probably broken rn, will test later

[dormieriancitizen]

Updated and tested for v3, all seems to be working. Also added a docs page.

[laggron42]

Wooo we're almost there (sorry for the insane delay)