Fixed idol gg#463
Open
12problems wants to merge 2 commits into
Open
Conversation
Toneblock
reviewed
Jun 9, 2026
| local threshold = 0 | ||
| for _, entry in ipairs(valid_idol_cards) do | ||
| threshold = threshold + (entry.count / total_weight) | ||
| threshold = threshold + (entry.total_score / total_weight) |
Collaborator
There was a problem hiding this comment.
entry.count's original purpose here is to weight each entry by the amount of cards in deck so idol selects (so idol selects king of hearts at 50% odds if the deck contains 50% king of hearts)
by replacing it with total_score, we're weighting each entry by their total score
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.