adds support for ClerkAuth#5
Merged
Merged
Conversation
… store says its not there, in order to catch issues where its not trying to log out if the session is remotely terminated
…vs protected layout options
Contributor
There was a problem hiding this comment.
Pull Request Overview
Adds initial support and end-to-end testing for ClerkAuth in the Dash Auth Plus library, updates dependencies, and provides usage documentation.
- Expose and document the new
ClerkAuthauthentication backend - Add CI and dev dependencies (
clerk-sdk,clerk-backend-api,python-dotenv) - Implement and test a full Clerk sign-in/sign-out flow with Selenium
Reviewed Changes
Copilot reviewed 8 out of 8 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| tests/test_clerk_auth.py | New end-to-end Selenium test validating ClerkAuth flow |
| setup.py | Added python-dotenv to install_requires and Clerk extras |
| dev-requirements.txt | Added Clerk SDK and backend API for local development |
| dash_auth_plus/auth.py | Removed stray whitespace |
| dash_auth_plus/init.py | Export ClerkAuth and helper function |
| README.md | Added example usage for ClerkAuth |
| .github/workflows/python-test.yml | Updated Python versions and added Clerk-related env vars |
Comments suppressed due to low confidence (1)
README.md:560
- In the README example, the path_template uses '{user_id}' instead of the required '<user_id>' syntax—update it to match the actual register_page API and avoid confusion.
register_page('private', path_template="/user/{user_id}/private", layout=user_private)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.