Clerk updates by BSd3v · Pull Request #13 · BSd3v/dash-auth-plus

BSd3v · 2026-03-04T18:07:49Z

No description provided.

… pass

…r protected for easier parsing of layout protections

Copilot

Pull request overview

Updates Clerk integration and related tooling/test fixtures in dash_auth_plus, plus a small enhancement to group-based protection.

Changes:

Adjust ClerkAuth client-side initialization/logout behavior and reduce repeated redirect-uri computation.
Add async support to group_protection.protected(...) for coroutine functions.
Tighten dev dependency bounds and make minor formatting/whitespace/build-script tweaks.

Reviewed changes

Copilot reviewed 9 out of 9 changed files in this pull request and generated 3 comments.

Show a summary per file

File	Description
`dash_auth_plus/clerk_auth.py`	Updates ClerkAuth init script/logout behavior and refactors redirect handling.
`dash_auth_plus/group_protection.py`	Adds an async wrapper path to `protected(...)`.
`dev-requirements.txt`	Adds upper bounds for Dash testing dependency and Black.
`dash_auth_plus/package-info.json`	Adjusts build copy command to flatten output.
`dash_auth_plus/oidc_auth.py`	Formatting-only changes to error/page string construction.
`dash_auth_plus/public_routes.py`	Removes extra blank lines (formatting-only).
`tests/test_clerk_auth.py`	Formatting-only change in test app layout.
`tests/test_basic_auth_integration.py`	Removes a stray blank line (formatting-only).

Comments suppressed due to low confidence (1)

dash_auth_plus/clerk_auth.py:189

self.auth_protect_layouts_kwargs is assigned but never read anywhere in this module (the value is already passed to Auth.__init__). Keeping an unused instance attribute makes the behavior harder to follow and can become stale. Either remove this assignment, or use the attribute instead of passing the kwargs through separately (but avoid storing it if it’s not needed).

        self.log_signins = log_signins
        self.logout_page = logout_page
        self._user_groups = user_groups

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>

Copilot · 2026-03-05T11:02:30Z

@BSd3v I've opened a new pull request, #14, to work on those changes. Once the pull request is ready, I'll request review from you.

Copilot · 2026-03-05T11:04:21Z

@BSd3v I've opened a new pull request, #15, to work on those changes. Once the pull request is ready, I'll request review from you.

Co-authored-by: BSd3v <82055130+BSd3v@users.noreply.github.com>

Add async test coverage for `protected()` decorator

…n screen

Copilot

Pull request overview

Copilot reviewed 10 out of 10 changed files in this pull request and generated 2 comments.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>

Copilot

Pull request overview

Copilot reviewed 10 out of 10 changed files in this pull request and generated 4 comments.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>

Copilot

Pull request overview

Copilot reviewed 10 out of 10 changed files in this pull request and generated 3 comments.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>

…y for comparrison

Copilot

Pull request overview

Copilot reviewed 11 out of 11 changed files in this pull request and generated 4 comments.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>

Copilot · 2026-03-16T17:36:47Z

@BSd3v I've opened a new pull request, #24, to work on those changes. Once the pull request is ready, I'll request review from you.

Co-authored-by: BSd3v <82055130+BSd3v@users.noreply.github.com>

…c-adb4-c8efdc612a1e Use cached page paths/adapter in `_redirect_test`

…p file

Copilot

Pull request overview

Copilot reviewed 11 out of 11 changed files in this pull request and generated 1 comment.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

BSd3v · 2026-03-16T18:28:28Z

+    signature = hashlib.sha256(repr(registry).encode()).hexdigest()
+    cache_key = f"dash_page_registry_{signature}"
+
+    page_paths = page_templates = None
+    if cache is not None:


@copilot

Does that defeat the purpose of the cache?

Copilot · 2026-03-16T18:28:39Z

@BSd3v I've opened a new pull request, #25, to work on those changes. Once the pull request is ready, I'll request review from you.

… page registry data Co-authored-by: BSd3v <82055130+BSd3v@users.noreply.github.com>

…a-a864-d116ca59b92f Replace unstable disk cache with in-process cache for page registry data

BSd3v added 2 commits March 4, 2026 13:07

updates for clerk flow

497e0fa

adds support for async layouts

40468d9

BSd3v temporarily deployed to test March 4, 2026 18:07 — with GitHub Actions Inactive

fixing missing js file for Clerk

38e35e4

BSd3v temporarily deployed to test March 4, 2026 18:21 — with GitHub Actions Inactive

adjustments for lint changes

2fb4f28

BSd3v temporarily deployed to test March 4, 2026 18:47 — with GitHub Actions Inactive

locking the dev requirements to less dash and black to allow tests to…

2962fcc

… pass

BSd3v temporarily deployed to test March 4, 2026 18:53 — with GitHub Actions Inactive

BSd3v requested a review from Copilot March 5, 2026 10:54

Copilot started reviewing on behalf of BSd3v March 5, 2026 10:55 View session

making handler a little more robust and also passing down the path fo…

e6d4531

…r protected for easier parsing of layout protections

BSd3v temporarily deployed to test March 5, 2026 10:57 — with GitHub Actions Inactive

Copilot AI reviewed Mar 5, 2026

View reviewed changes

Comment thread dash_auth_plus/clerk_auth.py Outdated

Comment thread dash_auth_plus/group_protection.py Outdated

Comment thread dash_auth_plus/group_protection.py

Update dash_auth_plus/clerk_auth.py

8e80886

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>

BSd3v temporarily deployed to test March 5, 2026 11:01 — with GitHub Actions Inactive

Copilot AI mentioned this pull request Mar 5, 2026

Clarify intentional un-awaited coroutine return in group_protection callback handler #14

Closed

Initial plan

8242f36

Copilot AI mentioned this pull request Mar 5, 2026

Add async test coverage for protected() decorator #15

Merged

Copilot AI and others added 2 commits March 5, 2026 11:06

Add test_gp004_protected_async for async protected() branch coverage

32dd24b

Co-authored-by: BSd3v <82055130+BSd3v@users.noreply.github.com>

Merge pull request #15 from BSd3v/copilot/sub-pr-13-again

19b1079

Add async test coverage for `protected()` decorator

BSd3v temporarily deployed to test March 5, 2026 11:12 — with GitHub Actions Inactive

adjustments for allowing protected layouts through to the custom logi…

58f867d

…n screen

Copilot AI reviewed Mar 13, 2026

View reviewed changes

Comment thread dash_auth_plus/clerk_auth.py Outdated

Comment thread dash_auth_plus/auth.py

BSd3v and others added 2 commits March 13, 2026 17:23

Potential fix for pull request finding

f232071

Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>

Potential fix for pull request finding

9831a84

Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>

Copilot AI reviewed Mar 13, 2026

View reviewed changes

Comment thread dash_auth_plus/auth.py Outdated

Comment thread dash_auth_plus/auth.py Outdated

Comment thread dash_auth_plus/group_protection.py

Comment thread dash_auth_plus/group_protection.py

BSd3v and others added 3 commits March 16, 2026 10:19

Potential fix for pull request finding

baf9e32

Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>

Potential fix for pull request finding

082f438

Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>

fixing errors

188db33

Copilot AI reviewed Mar 16, 2026

View reviewed changes

Comment thread dash_auth_plus/auth.py Outdated

Comment thread dash_auth_plus/auth.py Outdated

Comment thread dash_auth_plus/clerk_auth.py Outdated

BSd3v and others added 5 commits March 16, 2026 12:45

Potential fix for pull request finding

7a906d5

Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>

Potential fix for pull request finding

040ea3e

Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>

adjustments for using diskcache for local housing of the page registr…

133e4e0

…y for comparrison

adjustments for lint

87f8039

fix for lint

18cdc5c

Copilot AI reviewed Mar 16, 2026

View reviewed changes

Comment thread dash_auth_plus/auth.py Outdated

Comment thread dash_auth_plus/auth.py

Comment thread dash_auth_plus/auth.py Outdated

Comment thread dash_auth_plus/clerk_auth.py Outdated

BSd3v and others added 3 commits March 16, 2026 13:33

fixing registry in function call

02dc595

Potential fix for pull request finding

ab8bc5c

Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>

Initial plan

920d646

Copilot AI mentioned this pull request Mar 16, 2026

Use cached page paths/adapter in _redirect_test #24

Merged

Copilot AI and others added 4 commits March 16, 2026 17:41

Use cached _get_page_paths_and_adapter in _redirect_test

457bd4d

Co-authored-by: BSd3v <82055130+BSd3v@users.noreply.github.com>

Merge pull request #24 from BSd3v/copilot/sub-pr-13-1d8df084-c028-4f7…

07926f8

…c-adb4-c8efdc612a1e Use cached page paths/adapter in `_redirect_test`

fixing cache issues, adapter wasnt beneficial and moving cache to tem…

a86c98a

…p file

fixing for lint

f83a85b

Copilot AI reviewed Mar 16, 2026

View reviewed changes

Initial plan

981b230

Copilot AI mentioned this pull request Mar 16, 2026

Replace unstable disk cache with in-process cache for page registry data #25

Merged

5 tasks

Copilot AI and others added 2 commits March 16, 2026 18:32

Replace unstable disk cache with in-process module-level variable for…

73dcaa8

… page registry data Co-authored-by: BSd3v <82055130+BSd3v@users.noreply.github.com>

Merge pull request #25 from BSd3v/copilot/sub-pr-13-a304a475-d3e7-4ae…

dd5796c

…a-a864-d116ca59b92f Replace unstable disk cache with in-process cache for page registry data

Conversation

BSd3v commented Mar 4, 2026

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Reviewed changes

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Copilot AI commented Mar 5, 2026

Uh oh!

Copilot AI commented Mar 5, 2026

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Copilot AI commented Mar 16, 2026

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

BSd3v Mar 16, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI commented Mar 16, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants