Skip to content

Expanding Clerk Provider for Themes and Dash Eco-System Support#10

Merged
BSd3v merged 9 commits into
mainfrom
clerk-provider-expansion
Dec 5, 2025
Merged

Expanding Clerk Provider for Themes and Dash Eco-System Support#10
BSd3v merged 9 commits into
mainfrom
clerk-provider-expansion

Conversation

@BSd3v

@BSd3v BSd3v commented Dec 5, 2025

Copy link
Copy Markdown
Owner
  • adjustments for dash eco-system integration
  • allows for themes to be supported

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR adds theme support to the ClerkProvider component and includes critical bug fixes for Dash ecosystem integration. The changes enable users to apply Clerk's pre-built themes (dark, neobrutalism) to authentication UI components and fix a Python variable reference bug that would have caused runtime failures.

Key changes:

  • Added @clerk/themes package support with configurable theme selection via themeName prop
  • Fixed critical bug in clerk_auth.py where clerk_script was referenced without self. prefix
  • Enhanced ClerkProvider to accept additional props for Dash ecosystem integration

Reviewed changes

Copilot reviewed 4 out of 5 changed files in this pull request and generated 4 comments.

Show a summary per file
File Description
src/ts/components/ClerkProvider.tsx Added theme support with new props (themeName, id) and theme mapping logic; accepts additional props via spread operator
package.json Added @clerk/themes ^2.4.42 as dev dependency
package-lock.json Resolved dependencies for @clerk/themes and updated transitive dependencies (@clerk/shared, swr, use-sync-external-store)
dash_auth_plus/package-info.json Added @clerk/themes ^2.4.42 for consistency with main package.json
dash_auth_plus/clerk_auth.py Fixed variable reference bug: changed clerk_script to self.clerk_script

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread src/ts/components/ClerkProvider.tsx Outdated
Comment thread src/ts/components/ClerkProvider.tsx Outdated
Comment thread src/ts/components/ClerkProvider.tsx
Comment thread src/ts/components/ClerkProvider.tsx Outdated
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 4 out of 5 changed files in this pull request and generated 3 comments.


💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread src/ts/components/ClerkProvider.tsx Outdated
Comment thread src/ts/components/ClerkProvider.tsx
Comment thread src/ts/components/ClerkProvider.tsx Outdated
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>

Copilot AI commented Dec 5, 2025

Copy link
Copy Markdown
Contributor

@BSd3v I've opened a new pull request, #11, to work on those changes. Once the pull request is ready, I'll request review from you.

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 4 out of 5 changed files in this pull request and generated 1 comment.


💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread src/ts/components/ClerkProvider.tsx Outdated
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
@BSd3v BSd3v merged commit 335c920 into main Dec 5, 2025
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants