build(cmake): raise minimum CMake version to 3.22#379
Merged
Conversation
Raise Simphony's declared minimum CMake version to 3.22 across the main project, standalone examples, DD4hep plugin standalone mode, and the standalone SGLFW test target. Ubuntu 22.04 is the intended minimum supported platform baseline for Simphony, and its system package baseline includes CMake 3.22.1. The project now relies on CMake features such as `PROJECT_IS_TOP_LEVEL`, which are supported by CMake 3.22. Raising the declared minimum keeps the build requirements aligned with the supported platform policy and avoids older CMake versions silently misconfiguring testing defaults.
Contributor
There was a problem hiding this comment.
Pull request overview
Raises Simphony’s declared minimum required CMake version to 3.22 to match the Ubuntu 22.04 baseline and ensure newer CMake features (e.g., PROJECT_IS_TOP_LEVEL) behave consistently across the main build and standalone sub-projects.
Changes:
- Updated
cmake_minimum_required(...)to 3.22 in the top-level build and multiple standalone/example CMake projects. - Updated the DD4hep plugin standalone-mode CMake minimum to 3.22.
- Updated the Getting Started documentation to reflect the new CMake minimum.
Reviewed changes
Copilot reviewed 8 out of 8 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
CMakeLists.txt |
Raises the project-wide minimum CMake version to 3.22. |
dd4hepplugins/CMakeLists.txt |
Aligns standalone DD4hep plugin build minimum CMake to 3.22. |
examples/CMakeLists.txt |
Updates examples’ minimum CMake to 3.22. |
examples/MC_Truth/CMakeLists.txt |
Updates standalone MC_Truth example minimum CMake to 3.22. |
examples/async_gpu_std/CMakeLists.txt |
Updates standalone async_gpu_std example minimum CMake to 3.22. |
examples/async_gpu_launch/CMakeLists.txt |
Updates standalone async_gpu_launch example minimum CMake to 3.22. |
sysrap/SGLFW_tests/CMakeLists.txt |
Updates standalone SGLFW test target minimum CMake to 3.22. |
docs/getting-started.md |
Documents CMake 3.22+ as the minimum prerequisite. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Raise Simphony's declared minimum CMake version to 3.22 across the main project, standalone
examples, DD4hep plugin standalone mode, and the standalone SGLFW test target.
Ubuntu 22.04 is the intended minimum supported platform baseline for Simphony, and its system
package baseline includes CMake 3.22.1.
The project now relies on CMake features such as
PROJECT_IS_TOP_LEVEL, which are supported byCMake 3.22. Raising the declared minimum keeps the build requirements aligned with the supported
platform policy and avoids older CMake versions silently misconfiguring testing defaults.