Skip to content

ci(test): build and run external example#376

Open
plexoos wants to merge 1 commit into
mainfrom
build-example
Open

ci(test): build and run external example#376
plexoos wants to merge 1 commit into
mainfrom
build-example

Conversation

@plexoos

@plexoos plexoos commented Jun 22, 2026

Copy link
Copy Markdown
Member

No description provided.

Copilot AI review requested due to automatic review settings June 22, 2026 19:39

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Adds a CI validation step to ensure the built Docker image can compile and execute the repository’s example project (intended to validate “external consumer” usage via find_package(simphony)).

Changes:

  • Introduce a new workflow step that builds the CMake project under examples/ inside the PR’s Docker image.
  • Run the built example and assert it produces an expected output file (out/photons.npy).

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread .github/workflows/build-pull-request.yaml Outdated
Comment thread .github/workflows/build-pull-request.yaml Outdated

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 5e94ccaef0

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread .github/workflows/build-pull-request.yaml Outdated

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 4 out of 4 changed files in this pull request and generated 2 comments.

Comment thread examples/CMakeLists.txt Outdated
Comment thread .github/workflows/build-pull-request.yaml
@plexoos plexoos self-assigned this Jun 23, 2026
@plexoos plexoos added the ci label Jun 23, 2026
@plexoos plexoos force-pushed the build-example branch 2 times, most recently from 5b90d3a to a619dde Compare June 25, 2026 22:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants