Skip to content

feat(config): add typed event runtime options#355

Merged
plexoos merged 3 commits into
mainfrom
add-max-genstep-config
Jun 24, 2026
Merged

feat(config): add typed event runtime options#355
plexoos merged 3 commits into
mainfrom
add-max-genstep-config

Conversation

@plexoos

@plexoos plexoos commented Jun 8, 2026

Copy link
Copy Markdown
Member
  • Add event.max_genstep to app config and apply it through SEventConfig::SetMaxGenstep.
  • Add configurable event.mode_lite and event.mode_merge options with typed ModeLite / ModeMerge enums.
  • Introduce a shared named-enum config reader for string-valued config parameters.
  • Reuse the named-enum reader for event.mode, event.mode_lite, event.mode_merge, torch.gentype, and torch.type.
  • Keep config keys ordered consistently in config/dev.json and Config.

Behavior

  • mode_lite and mode_merge use string names such as "Unspecified", "Lite", and "Merged" instead of numeric values.
  • torch.gentype remains restricted to "TORCH".
  • Invalid torch.type values now fail with a clear config error instead of silently becoming T_UNDEF.

@plexoos plexoos self-assigned this Jun 8, 2026
@plexoos

plexoos commented Jun 8, 2026

Copy link
Copy Markdown
Member Author

@codex review

@plexoos plexoos added the enhancement New feature or request label Jun 8, 2026
@chatgpt-codex-connector

Copy link
Copy Markdown

Codex Review: Didn't find any major issues. Nice work!

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

plexoos added 3 commits June 23, 2026 13:49
This adds support for configuring max_genstep through the app config and applies it to runtime event
configuration. This enables controlling genstep allocation limits through configuration instead of
hardcoded behavior, making debug and stress setups easier to tune.
@plexoos plexoos force-pushed the add-max-genstep-config branch from 0cc1b15 to 26a7d64 Compare June 23, 2026 22:10
@plexoos plexoos changed the title feat(config): add max_genstep event option and wire it to runtime config feat(config): add typed event runtime options Jun 23, 2026
@plexoos plexoos marked this pull request as ready for review June 23, 2026 22:12
Copilot AI review requested due to automatic review settings June 23, 2026 22:12

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR extends the application-level configuration layer (gphox::Config) to support additional event runtime options (max gensteps, lite storage mode, merge mode) and centralizes string-to-enum parsing via a shared named-enum reader, then synchronizes these settings into SEventConfig in Config::Apply().

Changes:

  • Added event.max_genstep to config/state and applied it via SEventConfig::SetMaxGenstep.
  • Introduced typed ModeLite / ModeMerge enums and corresponding event.mode_lite / event.mode_merge string config options, applied conditionally.
  • Reworked string-valued enum config parsing with a shared named-enum reader and reused it for event.mode, torch.gentype, and torch.type (now rejecting invalid torch.type values with a clear error).

Reviewed changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.

File Description
sysrap/config.h Adds ModeLite/ModeMerge enums and new Config fields (max_genstep, mode_lite, mode_merge) aligned with event runtime options.
sysrap/config.cpp Implements a generic named-enum reader, updates config parsing for event/torch enum-like fields, and applies new options to SEventConfig.
config/dev.json Adds event.max_genstep, event.mode_lite, and event.mode_merge keys and keeps ordering consistent with Config.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@plexoos plexoos merged commit 649ad28 into main Jun 24, 2026
14 checks passed
@plexoos plexoos deleted the add-max-genstep-config branch June 24, 2026 02:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants