release: v7.11.1 — honest Multiplicity.max typing + idiomatic empty lists#568
Merged
Conversation
- Update Multiplicity and Method classes to support Literal["*"] for max multiplicity - Change `list()` to `[]` per the suggested Sonarqube rule for code quality (https://next.sonarqube.com/sonarqube/coding_rules?open=python%3AS7498&rule_key=python%3AS7498)
The max setter normalises * to UNLIMITED_MAX_MULTIPLICITY, so the stored value and getter are always int. Keep the setter/__init__ input as int | Literal["*"] (it genuinely accepts "*"), but annotate the stored attribute and getter as int to reflect what is actually returned. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
fix(structural): honest multiplicity max types and idiomatic empty lists
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Multiplicity.maxhonest typing (fix(structural): honest multiplicity max types and idiomatic empty lists #564): the constructor andmaxsetter now declareint | Literal["*"](the setter already normalizes"*"→UNLIMITED_MAX_MULTIPLICITY); the getter staysint. Fixes a false type error for callers/checkers passing"*".list()→[]inMethodparameter/pre/post init (SonarQubepython:S7498).Test plan
structural.pyimports on 3.11 (int | Literal["*"]is import-time-evaluated; PEP 604, safe 3.10–3.12)Multiplicity(1, "*").max→9999;Method()→ empty[]lists