chore(versions): bump pinned tool versions and unify kubelogin between settings and templates#2278
Draft
bosesuneha wants to merge 1 commit into
Draft
chore(versions): bump pinned tool versions and unify kubelogin between settings and templates#2278bosesuneha wants to merge 1 commit into
bosesuneha wants to merge 1 commit into
Conversation
…n settings and templates
Two related problems addressed:
1. Every pinned third-party tool version was stale. Bump to current stable:
- azure.kubelogin.releaseTag: v0.0.31 -> v0.2.19
- azure.kubectlgadget.releaseTag: v0.51.0 -> v0.53.2
- aks.drafttool.releaseTag: v0.0.38 -> v0.17.14
(v0.17.15 exists but has no uploaded assets yet)
- aks.retinatool.releaseTag: v0.0.26 -> v1.2.2
- aks.aksmcpserver.releaseTag: v0.0.17 -> v0.0.19
2. Kubelogin was pinned in TWO places that disagreed: the setting default
above, and a hard-coded 'v0.0.25' in four generated-workflow templates.
Generated CI was silently using a different (older) kubelogin than the
local CLI, and there was no mechanism to keep them in sync.
Fix: replace the hard-coded value in all four templates with a new
{ { KUBELOGINVERSION } } placeholder. workflowTemplate.ts substitutes
the current azure.kubelogin.releaseTag setting value at generation time
so user overrides propagate into freshly generated workflows.
A KUBELOGIN_FALLBACK_VERSION constant provides the value when the
setting isn't readable (e.g. in unit tests that don't boot VS Code
config); it is kept in sync with the package.json default.
Docs: added a 'Pinned tool versions' section to docs/book/src/release/releasing.md
with a table of settings, upstream repos, and a one-liner shell snippet to
check for updates each release, so this drifts less next time.
Tests: two new assertions in workflowTemplate.test.ts confirm the placeholder
is substituted with a well-formed semver tag in both the single-container
and multi-container templates, and that every deploy job in the multi-container
variant uses the same version.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Addresses "stop defaulting to old tool versions" and "update tool versions in generated workflows" from the feedback doc.
Version bumps
azure.kubelogin.releaseTagv0.0.31v0.2.19azure.kubectlgadget.releaseTagv0.51.0v0.53.2aks.drafttool.releaseTagv0.0.38v0.17.14aks.retinatool.releaseTagv0.0.26v1.2.2aks.aksmcpserver.releaseTagv0.0.17v0.0.19Platform assets verified for each. Draft skipped
v0.17.15because its assets aren't uploaded yet.Kubelogin split-brain fix
Setting default was
v0.0.31but 4 workflow templates hard-codedv0.0.25. Replaced the hard-code with a{ { KUBELOGINVERSION } }placeholder thatworkflowTemplate.tssubstitutes from the current setting value at generation time.Docs
New "Pinned tool versions" section in
docs/book/src/release/releasing.mdwith an update-check snippet so these get reviewed each release.Tests
207 passing (+2): both renderers substitute the placeholder with a well-formed
vX.Y.Z, and every deploy job in the multi-container variant uses the same version.