Skip to content
This repository was archived by the owner on Jun 2, 2026. It is now read-only.

feat(subscription): add defender for cloud security contact configuration#339

Open
felipebbc wants to merge 7 commits into
Azure:mainfrom
felipebbc:feat/defendercontact
Open

feat(subscription): add defender for cloud security contact configuration#339
felipebbc wants to merge 7 commits into
Azure:mainfrom
felipebbc:feat/defendercontact

Conversation

@felipebbc

@felipebbc felipebbc commented Feb 27, 2024

Copy link
Copy Markdown

Overview/summary

Enable Microsoft Defender for Cloud contact settings within the subscription

Options:

  • Create the security contact configuration
  • Enable email notifications about new security alerts
  • Enable email notifications from Microsoft Defender for Cloud to persons with specific RBAC roles on the subscription

This PR fixes/adds/changes/removes

  1. feat: add an email recipient for the email notification of Defender for Cloud #277

Testing evidence

dfc_contact_evidence1
dfc_contact_evidence2

As part of this pull request I have

  • Checked for duplicate Pull Requests
  • Associated it with relevant issues, for tracking and closure.
  • Run and make fmt & make docs to format your code and update documentation.
  • Created unit and deployment tests and provided evidence.
  • Updated relevant and associated documentation.

@felipebbc
felipebbc marked this pull request as ready for review February 27, 2024 22:32
@felipebbc
felipebbc requested a review from a team as a code owner February 27, 2024 22:32
@felipebbc
felipebbc force-pushed the feat/defendercontact branch 3 times, most recently from 9a38335 to f0933a4 Compare February 29, 2024 15:21

@Christian12cc Christian12cc left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

impressive work
thanks

Comment thread modules/subscription/main.tf Outdated
@matt-FFFFFF

Copy link
Copy Markdown
Member

This looks great thanks for your efforts!

@felipebbc
felipebbc force-pushed the feat/defendercontact branch 2 times, most recently from f394a61 to f3ad0cb Compare March 3, 2024 01:28
@matt-FFFFFF

Copy link
Copy Markdown
Member

I see more commits tricking in. Are you happy with this work now @felipebbc ?

@felipebbc

Copy link
Copy Markdown
Author

I see more commits tricking in. Are you happy with this work now @felipebbc ?

Yes. Had to ignore the “location” field since it cannot be set by deployment, but it is set by Azure causing a change on subsequent runs.

I’m good with this.

@felipebbc
felipebbc force-pushed the feat/defendercontact branch from 4c4e7a4 to b153276 Compare May 31, 2024 16:48
@felipebbc

Copy link
Copy Markdown
Author

Hi @matt-FFFFFF Anything pending from me to get this PR approved?

@matt-FFFFFF

Copy link
Copy Markdown
Member

Hi yes the check failures need addressing

(make docs && make fmt)

@felipebbc

Copy link
Copy Markdown
Author

Hi yes the check failures need addressing

(make docs && make fmt)

Updated. Thank you.

@matt-FFFFFF
matt-FFFFFF enabled auto-merge June 7, 2024 21:49
matt-FFFFFF
matt-FFFFFF previously approved these changes Jun 7, 2024
auto-merge was automatically disabled June 8, 2024 03:41

Head branch was pushed to by a user without write access

@felipebbc
felipebbc force-pushed the feat/defendercontact branch 3 times, most recently from 0b1c1c1 to a3a2fed Compare June 8, 2024 04:36
felipebbc and others added 6 commits June 8, 2024 00:40
Signed-off-by: felipebbc <33853312+felipebbc@users.noreply.github.com>
…tting

Signed-off-by: felipebbc <33853312+felipebbc@users.noreply.github.com>
…e provided

Signed-off-by: felipebbc <33853312+felipebbc@users.noreply.github.com>
Signed-off-by: felipebbc <33853312+felipebbc@users.noreply.github.com>
Signed-off-by: felipebbc <33853312+felipebbc@users.noreply.github.com>
Signed-off-by: felipebbc <33853312+felipebbc@users.noreply.github.com>
@felipebbc
felipebbc force-pushed the feat/defendercontact branch from a3a2fed to b652b57 Compare June 8, 2024 04:40
@jvik

jvik commented Dec 10, 2024

Copy link
Copy Markdown

Any update on this? Would be very useful for our organization.

@qaiserali

Copy link
Copy Markdown

Any updates on this? We are also looking for this function.

@matt-FFFFFF

Copy link
Copy Markdown
Member

Hi there,

We've been getting the v5 branch ready for release. This is a major refactor. Once merged we will look at this before we release. Sorry for the delay!

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

PR: Safe to test 🧪 PRs can run deployment tests

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants