Skip to content

[WIP] Add RHEL SAP HANA SR-ANGI configuration and validation support#284

Draft
devanshjainms wants to merge 18 commits into
Azure:development-june-2026from
devanshjainms:rhel-angi
Draft

[WIP] Add RHEL SAP HANA SR-ANGI configuration and validation support#284
devanshjainms wants to merge 18 commits into
Azure:development-june-2026from
devanshjainms:rhel-angi

Conversation

@devanshjainms

Copy link
Copy Markdown
Contributor

This pull request introduces comprehensive support for SAP HANA scale-up clusters using the SAPHanaSR-angi provider on RHEL. It adds new configuration options, resource templates, and validation logic for the angi provider, updates the constants and expected resource definitions, and extends the test suite to cover these new scenarios. The changes ensure that the system can now correctly recognize, validate, and manage SAP HANA clusters configured with SAPHanaSR-angi on RHEL.

Key changes include:

Support for SAPHanaSR-angi Provider on RHEL:

  • Added new resource templates and validation logic for angi resources (angi_topology, angi_hana, angi_filesystem) in RESOURCE_DEFAULTS and updated RESOURCE_CATEGORIES and active category selection in get_pcmk_properties_db.py. [1] [2] [3] [4] [5]
  • Introduced angi-specific cluster configuration parameters in VALID_CONFIGS and updated expected values in test constants. [1] [2]

Configuration and Hook Updates:

  • Added SAPHanaSR-angi provider and ChkSrv hook configuration to GLOBAL_INI, including execution order and action_on_lost settings.
  • Updated the indexserver check logic to recognize the angi ChkSrv hook and added corresponding test coverage. [1] [2]

Testing Enhancements:

  • Added fixtures and tests for angi resource and provider handling, including node attribute processing and provider config derivation for RHEL angi clusters. [1] [2]
  • Introduced new dummy XML and INI data for RHEL angi cluster scenarios in test files.

These changes collectively enable robust support and validation for SAP HANA clusters using SAPHanaSR-angi on RHEL, ensuring correct configuration, resource management, and test coverage.

@devanshjainms devanshjainms requested a review from a team as a code owner June 2, 2026 21:30
@devanshjainms devanshjainms requested review from KimForss and Copilot June 2, 2026 21:30
@devanshjainms devanshjainms changed the title Add RHEL SAP HANA SR-ANGI configuration and validation support [WIP] Add RHEL SAP HANA SR-ANGI configuration and validation support Jun 2, 2026
@devanshjainms devanshjainms added the enhancement New feature or request label Jun 2, 2026
@devanshjainms devanshjainms marked this pull request as draft June 2, 2026 21:30

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR extends the HA validation and status-checking logic to support RHEL scale-up clusters using the SAPHanaSR-angi provider, adding angi-specific Pacemaker resource expectations, global.ini hook expectations, and corresponding test coverage.

Changes:

  • Added angi scale-up configuration expectations (angi_scale_up) and angi resource defaults (topology/controller/filesystem) to the HA constants.
  • Extended DB Pacemaker properties validation to switch active resource categories for angi and attempt clone-level meta validation for angi resources.
  • Updated indexserver configuration detection and added/extended tests for RHEL angi scenarios.

Reviewed changes

Copilot reviewed 6 out of 6 changed files in this pull request and generated 1 comment.

Show a summary per file
File Description
src/modules/get_pcmk_properties_db.py Adds angi clone meta resource-category selectors and updates active-category selection for angi scale-up.
src/modules/check_indexserver.py Allows an additional valid RedHat ChkSrv hook path for angi (/usr/share/sap-hana-ha).
src/roles/ha_db_hana/tasks/files/constants.yaml Introduces angi scale-up validation keys and angi resource/global.ini expectations.
tests/modules/get_pcmk_properties_db_test.py Adds dummy RHEL angi CIB/global.ini inputs and validation tests for angi categories/resources/hooks.
tests/modules/get_cluster_status_db_test.py Adds RHEL angi naming/provider-config derivation tests for status checker behavior.
tests/modules/check_indexserver_test.py Adds a RedHat angi ChkSrv hook scenario test.

Comment on lines +190 to +192
"angi_topology_meta": ".//clone/primitive[@type='SAPHanaTopology']/../meta_attributes",
"angi_hana_meta": ".//clone/primitive[@type='SAPHanaController']/../meta_attributes",
"angi_filesystem_meta": ".//clone/primitive[@type='SAPHanaFilesystem']/../meta_attributes",

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@copilot we have a unit test that validates this code and it works fine = it is able to parse the meta attributes

@devanshjainms devanshjainms changed the base branch from development-may-2026 to development-june-2026 June 4, 2026 17:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants