[WIP] Add RHEL SAP HANA SR-ANGI configuration and validation support#284
Draft
devanshjainms wants to merge 18 commits into
Draft
[WIP] Add RHEL SAP HANA SR-ANGI configuration and validation support#284devanshjainms wants to merge 18 commits into
devanshjainms wants to merge 18 commits into
Conversation
There was a problem hiding this comment.
Pull request overview
This PR extends the HA validation and status-checking logic to support RHEL scale-up clusters using the SAPHanaSR-angi provider, adding angi-specific Pacemaker resource expectations, global.ini hook expectations, and corresponding test coverage.
Changes:
- Added angi scale-up configuration expectations (
angi_scale_up) and angi resource defaults (topology/controller/filesystem) to the HA constants. - Extended DB Pacemaker properties validation to switch active resource categories for angi and attempt clone-level meta validation for angi resources.
- Updated indexserver configuration detection and added/extended tests for RHEL angi scenarios.
Reviewed changes
Copilot reviewed 6 out of 6 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
src/modules/get_pcmk_properties_db.py |
Adds angi clone meta resource-category selectors and updates active-category selection for angi scale-up. |
src/modules/check_indexserver.py |
Allows an additional valid RedHat ChkSrv hook path for angi (/usr/share/sap-hana-ha). |
src/roles/ha_db_hana/tasks/files/constants.yaml |
Introduces angi scale-up validation keys and angi resource/global.ini expectations. |
tests/modules/get_pcmk_properties_db_test.py |
Adds dummy RHEL angi CIB/global.ini inputs and validation tests for angi categories/resources/hooks. |
tests/modules/get_cluster_status_db_test.py |
Adds RHEL angi naming/provider-config derivation tests for status checker behavior. |
tests/modules/check_indexserver_test.py |
Adds a RedHat angi ChkSrv hook scenario test. |
Comment on lines
+190
to
+192
| "angi_topology_meta": ".//clone/primitive[@type='SAPHanaTopology']/../meta_attributes", | ||
| "angi_hana_meta": ".//clone/primitive[@type='SAPHanaController']/../meta_attributes", | ||
| "angi_filesystem_meta": ".//clone/primitive[@type='SAPHanaFilesystem']/../meta_attributes", |
Contributor
Author
There was a problem hiding this comment.
@copilot we have a unit test that validates this code and it works fine = it is able to parse the meta attributes
…cores for primary worker nodes and add corresponding unit tests
…nd secondary worker nodes
…guments with error logging
…nd add network restoration in case of failure
…es rules for better error handling and network restoration
…ork restoration conditions
… configurations, and add on-fail handling option
…ecks and improve condition handling
…s and streamline test execution result handling
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request introduces comprehensive support for SAP HANA scale-up clusters using the SAPHanaSR-angi provider on RHEL. It adds new configuration options, resource templates, and validation logic for the angi provider, updates the constants and expected resource definitions, and extends the test suite to cover these new scenarios. The changes ensure that the system can now correctly recognize, validate, and manage SAP HANA clusters configured with SAPHanaSR-angi on RHEL.
Key changes include:
Support for SAPHanaSR-angi Provider on RHEL:
angi_topology,angi_hana,angi_filesystem) inRESOURCE_DEFAULTSand updatedRESOURCE_CATEGORIESand active category selection inget_pcmk_properties_db.py. [1] [2] [3] [4] [5]VALID_CONFIGSand updated expected values in test constants. [1] [2]Configuration and Hook Updates:
GLOBAL_INI, including execution order and action_on_lost settings.Testing Enhancements:
These changes collectively enable robust support and validation for SAP HANA clusters using SAPHanaSR-angi on RHEL, ensuring correct configuration, resource management, and test coverage.