feat: introduce content processing v2 changes#6970
Open
Shreyas-Microsoft wants to merge 46 commits into
Open
Conversation
…etwork resource to reduce compiled template size and avoid 4MB validation payload failures.
…compiled json - Precompile .bicep to temp .json in avm-validateModuleDeployment action and use it for Test/New-TemplateDeployment - Reduce content-processing e2e payload by removing init/idem iteration from defaults/sandbox/waf-aligned tests - Regenerate module artifacts via Set-AVMModule
- Skip pre-validation for near-4MB compiled templates in validate step - Point content-processing e2e tests to main.json module artifact to reduce bicep expansion variability
Co-authored-by: Copilot <copilot@github.com>
Co-authored-by: Copilot <copilot@github.com>
Co-authored-by: Copilot <copilot@github.com>
microsoft-github-policy-service
Bot
added
Needs: Triage 🔍
Co-authored-by: Copilot <copilot@github.com>
Prajwal-Microsoft
approved these changes
May 8, 2026
Co-authored-by: Copilot <copilot@github.com>
Collaborator
|
Hola @Dongbumlee / @brittneek, please review when you get the chance 🙏 |
Dongbumlee
previously approved these changes
May 11, 2026
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
auto-merge was automatically disabled
May 15, 2026 11:56
Head branch was pushed to by a user without write access
…over comments and redundant test params - Remove commented-out param block in modules/key-vault.bicep (top of file) - Remove commented-out diagnosticSettings param block in modules/key-vault.bicep - Remove leftover scaffold comment in tests/e2e/defaults/main.test.bicep - Drop redundant 'location' param from defaults test (RG scope already provides it) Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Dongbumlee
previously approved these changes
May 19, 2026
Address PR Azure#6970 review comment from @AlexanderSehr: the defaults test should exercise the module's defaults, not opt-in to specific properties. Removed from defaults/main.test.bicep: - enablePrivateNetworking: false (matches default, redundant) - enableMonitoring: false (matches default, redundant) - enableRedundancy: true (overrides default false) - enableScalability: true (overrides default false) - cosmosDbReplicaLocation: 'canadacentral' (only required when enableRedundancy=true) Kept solutionName (CI naming hygiene), azureAiServiceLocation (required), and gptDeploymentCapacity (quota-friendly override). The non-default flag combinations remain covered by sandbox (all-off) and waf-aligned (all-on) scenarios.
…Cosmos failover handling - Flip enablePrivateNetworking, enableMonitoring, enableRedundancy and enableScalability defaults from false to true so the 'defaults' test scenario exercises the module's real defaults; 'sandbox' still explicitly opts out. - Fix description of enablePrivateNetworking (was incorrectly labelled 'Enable WAF for the deployment.') and rewrite cosmosDbReplicaLocation description from Conditional to Optional. - Harden Cosmos DB failoverLocations: when enableRedundancy is true with no cosmosDbReplicaLocation, deploy a single zone-redundant region instead of passing a null locationName. - Regenerate main.json and README.md via Set-AVMModule and update CHANGELOG. BREAKING CHANGE: Default values of enablePrivateNetworking, enableMonitoring, enableRedundancy and enableScalability are now true. Consumers relying on the previous lightweight defaults must explicitly set the flags they want disabled. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Collaborator
|
Hola @brittneek & @aniaroramsft, please review when you get the chance 🙏 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This pull request introduces several improvements and fixes to the Content Processing Solution Accelerator module, focusing on input cleanup, validation enhancements, and documentation updates. The most significant changes are the removal of certain input paths, fixes to template validation, and updates to supported resource types and documentation for clarity and compliance.
Module input and validation improvements:
Deployment and validation script enhancements:
.github/actions/templates/avm-validateModuleDeployment/action.yml) to compile.bicepfiles to JSON before validation, use the resolved template path, and skip pre-validation for templates close to the 4 MB limit to avoid request size errors. [1] [2] [3] [4] [5]Documentation and resource type updates:
README.mdfor clarity, emphasizing AVM compliance and simplifying the introduction.Microsoft.CognitiveServices/accountsandMicrosoft.Compute/proximityPlacementGroups, and removed deprecated preview versions.These changes collectively improve the usability, compliance, and reliability of the module while keeping documentation and supported resources up to date.
Pipeline Reference
Type of Change
version.json:version.json.version.json.Checklist
Set-AVMModulelocally to generate the supporting module files.