fix: DevOps CI/CD agents pattern module DNS properties were not used and added dnsIsDeployedByPolicy property

[johnlokerse]

Description

Ran into some DNS issues when bringing your own DNS setup and when using DINE policies. This pull request removes privateDnsZoneGroupName and privateDnsZoneResourceIds in module acr. These properties were not used. Updated them to the correct properties as defined in the UDT. Additionally, added the parameter dnsIsDeployedByPolicy to be able to skip the configuration of privateDnsZoneGroups.

Updated modules to the latest version.

Pipeline Reference

Do you have an environment set up @sebassem so this change can be tested?

Type of Change

• Azure Verified Module updates:
  • Bugfix containing backwards-compatible bug fixes, and I have NOT bumped the MAJOR or MINOR version in version.json:
  • Feature update backwards compatible feature updates, and I have bumped the MINOR version in version.json.
  • Breaking changes and I have bumped the MAJOR version in version.json.
  • Update to documentation
• Update to CI Environment or utilities (Non-module affecting changes)

Checklist

• I'm sure there are no other open Pull Requests for the same update/change
• I have run Set-AVMModule locally to generate the supporting module files.
• My corresponding pipelines / checks run clean and green without any errors or warnings
• I have updated the module's CHANGELOG.md file with an entry for the next version

[microsoft-github-policy-service]

Important

The "Needs: Triage 🔍" label must be removed once the triage process is complete!

Tip

For additional guidance on how to triage this issue/PR, see the BRM Issue Triage documentation.

[microsoft-github-policy-service]

Important

If this is a module-related PR, being submitted by the sole owner of the module, the AVM core team must review and approve it (as module owners can't approve their own PRs).

To indicate this PR needs the core team''s attention, apply the "Needs: Core Team 🧞" label!

The core team will only review and approve PRs that have this label applied!

[sebassem]

LGTM

[jtracey93]

@johnlokerse can you resolve the merge conflicts

[johnlokerse]

@jtracey93 Done, but I have some issues with generating the README via Set-AVMModule command. This pattern module does not have a waf-aligned e2e test but the command creates it, resulting in errors because the generated waf-aligned tests have module errors. See console output:

[AlexanderSehr]

@jtracey93 Done, but I have some issues with generating the README via Set-AVMModule command. This pattern module does not have a waf-aligned e2e test but the command creates it, resulting in errors because the generated waf-aligned tests have module errors. See console output:

Regarding this @johnlokerse, please run the script with the corresponding skips. For example:
Set-AvmModule -ModuleFolderPath '<path>' -SkipFileAndFolderSetup -ThrottleLimit 10.

Maybe it's time to flip this skip-switch parameter on its head.

[johnlokerse]

Set-AvmModule -ModuleFolderPath '' -SkipFileAndFolderSetup -ThrottleLimit 10

That works! Pushed changes.

[AlexanderSehr]

Closing in favor of #7030

@johnlokerse you'll remain the author of the changes as I just rebased the PR to resolve the conflicts.