[AutoPR Azure.ResourceManager.Compute]-generated-from-SDK Generation - .NET-6479802#60234
[AutoPR Azure.ResourceManager.Compute]-generated-from-SDK Generation - .NET-6479802#60234azure-sdk wants to merge 5 commits into
Conversation
…pute/Compute/tspconfig.yaml', SDK Release Type: stable, and CommitSHA: 'f1afa57769d1e6267fb93258cf23229efc7edd0f' in SpecRepo: 'https://github.com/Azure/azure-rest-api-specs' Pipeline run: https://dev.azure.com/azure-sdk/internal/_build/results?buildId=6479802 Refer to https://eng.ms/docs/products/azure-developer-experience/develop/sdk-release/sdk-release-prerequisites to prepare for SDK release.
azure-sdk
requested review from
ArcturusZhang,
ArthurMa1978 and
live1206
as code owners
github-actions
Bot
added
the
Mgmt
There was a problem hiding this comment.
Pull request overview
This PR updates Azure.ResourceManager.Compute from the azure-rest-api-specs Compute TypeSpec configuration at commit f1afa57769d1e6267fb93258cf23229efc7edd0f, regenerating the SDK with newer default API versions and adding new generated APIs (notably snapshot immutability policy operations and shared gallery invite accept/reject operations). It also promotes the package version to 1.15.0.
Changes:
- Bump TypeSpec source commit and update default API versions for multiple Compute resource clients.
- Add snapshot immutability policy models/properties and new
SnapshotResourceoperations. - Add generated REST operations + mocking extensions for shared gallery invite accept/reject scenarios.
Reviewed changes
Copilot reviewed 6 out of 61 changed files in this pull request and generated 4 comments.
Show a summary per file
| File | Description |
|---|---|
| sdk/compute/Azure.ResourceManager.Compute/tsp-location.yaml | Updates the spec commit SHA used for TypeSpec-based generation. |
| sdk/compute/Azure.ResourceManager.Compute/src/Generated/SnapshotResource.cs | Bumps snapshot API version and adds immutability policy update/lock operations. |
| sdk/compute/Azure.ResourceManager.Compute/src/Generated/SnapshotData.cs | Adds ImmutabilityPolicy to snapshot data surface. |
| sdk/compute/Azure.ResourceManager.Compute/src/Generated/SnapshotCollection.cs | Bumps default snapshot API version across collection operations. |
| sdk/compute/Azure.ResourceManager.Compute/src/Generated/RestOperations/TenantLevelSharedGalleryInvitesRestOperations.cs | Adds generated REST request builders for tenant-level shared gallery invite accept/reject. |
| sdk/compute/Azure.ResourceManager.Compute/src/Generated/RestOperations/SnapshotsRestOperations.cs | Adds REST request builders for snapshot immutability policy update/lock endpoints. |
| sdk/compute/Azure.ResourceManager.Compute/src/Generated/RestOperations/SharedGalleryInvitesRestOperations.cs | Adds generated REST request builders for subscription-level shared gallery invite accept/reject. |
| sdk/compute/Azure.ResourceManager.Compute/src/Generated/Models/SnapshotProperties.Serialization.cs | Adds (de)serialization support for snapshot immutabilityPolicy. |
| sdk/compute/Azure.ResourceManager.Compute/src/Generated/Models/SnapshotProperties.cs | Adds ImmutabilityPolicy to snapshot properties model. |
| sdk/compute/Azure.ResourceManager.Compute/src/Generated/Models/ImmutabilityPolicyType.cs | Introduces an extensible enum for immutability policy type. |
| sdk/compute/Azure.ResourceManager.Compute/src/Generated/Models/ImmutabilityPolicyLockData.Serialization.cs | Adds serialization for immutability policy lock request model. |
| sdk/compute/Azure.ResourceManager.Compute/src/Generated/Models/ImmutabilityPolicyLockData.cs | Adds request model used to lock a snapshot immutability policy. |
| sdk/compute/Azure.ResourceManager.Compute/src/Generated/Models/ImmutabilityPolicyData.Serialization.cs | Adds serialization for immutability policy update request model. |
| sdk/compute/Azure.ResourceManager.Compute/src/Generated/Models/ImmutabilityPolicyData.cs | Adds request model used to update/extend a snapshot immutability policy. |
| sdk/compute/Azure.ResourceManager.Compute/src/Generated/Models/ImmutabilityPolicy.Serialization.cs | Adds serialization for the snapshot immutability policy response model. |
| sdk/compute/Azure.ResourceManager.Compute/src/Generated/Models/ImmutabilityPolicy.cs | Adds the snapshot immutability policy response model. |
| sdk/compute/Azure.ResourceManager.Compute/src/Generated/Models/DiskSecurityProfile.Serialization.cs | Adds (de)serialization for confidentialVMVersion. |
| sdk/compute/Azure.ResourceManager.Compute/src/Generated/Models/DiskSecurityProfile.cs | Adds ConfidentialVMVersion to disk security profile model. |
| sdk/compute/Azure.ResourceManager.Compute/src/Generated/Models/DiskRestorePointProperties.Serialization.cs | Adds (de)serialization for disk restore point snapshotAccessState. |
| sdk/compute/Azure.ResourceManager.Compute/src/Generated/Models/DiskRestorePointProperties.cs | Adds SnapshotAccessState to disk restore point properties model. |
| sdk/compute/Azure.ResourceManager.Compute/src/Generated/Models/ConfidentialVMVersion.cs | Introduces extensible enum-like type for confidential VM version. |
| sdk/compute/Azure.ResourceManager.Compute/src/Generated/Models/AzureResourceManagerComputeContext.cs | Registers new models as ModelReaderWriterBuildable. |
| sdk/compute/Azure.ResourceManager.Compute/src/Generated/ManagedDiskResource.cs | Bumps default managed disk API version. |
| sdk/compute/Azure.ResourceManager.Compute/src/Generated/ManagedDiskCollection.cs | Bumps default managed disk collection API version. |
| sdk/compute/Azure.ResourceManager.Compute/src/Generated/GalleryScriptVersionResource.cs | Bumps default gallery script version API version. |
| sdk/compute/Azure.ResourceManager.Compute/src/Generated/GalleryScriptVersionCollection.cs | Bumps default gallery script version collection API version. |
| sdk/compute/Azure.ResourceManager.Compute/src/Generated/GalleryScriptResource.cs | Bumps default gallery script API version. |
| sdk/compute/Azure.ResourceManager.Compute/src/Generated/GalleryScriptCollection.cs | Bumps default gallery script collection API version. |
| sdk/compute/Azure.ResourceManager.Compute/src/Generated/GalleryResource.cs | Bumps default gallery API version. |
| sdk/compute/Azure.ResourceManager.Compute/src/Generated/GalleryInVmAccessControlProfileVersionResource.cs | Bumps default in-VM access control profile version API version. |
| sdk/compute/Azure.ResourceManager.Compute/src/Generated/GalleryInVmAccessControlProfileVersionCollection.cs | Bumps default in-VM access control profile version collection API version. |
| sdk/compute/Azure.ResourceManager.Compute/src/Generated/GalleryInVmAccessControlProfileResource.cs | Bumps default in-VM access control profile API version. |
| sdk/compute/Azure.ResourceManager.Compute/src/Generated/GalleryInVmAccessControlProfileCollection.cs | Bumps default in-VM access control profile collection API version. |
| sdk/compute/Azure.ResourceManager.Compute/src/Generated/GalleryImageVersionResource.cs | Bumps default gallery image version API version. |
| sdk/compute/Azure.ResourceManager.Compute/src/Generated/GalleryImageVersionCollection.cs | Bumps default gallery image version collection API version. |
| sdk/compute/Azure.ResourceManager.Compute/src/Generated/GalleryImageResource.cs | Bumps default gallery image API version. |
| sdk/compute/Azure.ResourceManager.Compute/src/Generated/GalleryImageCollection.cs | Bumps default gallery image collection API version. |
| sdk/compute/Azure.ResourceManager.Compute/src/Generated/GalleryCollection.cs | Bumps default gallery collection API version. |
| sdk/compute/Azure.ResourceManager.Compute/src/Generated/GalleryApplicationVersionResource.cs | Bumps default gallery application version API version. |
| sdk/compute/Azure.ResourceManager.Compute/src/Generated/GalleryApplicationVersionCollection.cs | Bumps default gallery application version collection API version. |
| sdk/compute/Azure.ResourceManager.Compute/src/Generated/GalleryApplicationResource.cs | Bumps default gallery application API version. |
| sdk/compute/Azure.ResourceManager.Compute/src/Generated/GalleryApplicationCollection.cs | Bumps default gallery application collection API version. |
| sdk/compute/Azure.ResourceManager.Compute/src/Generated/Extensions/MockableComputeTenantResource.cs | Adds mockable tenant-level shared gallery invite accept/reject operations. |
| sdk/compute/Azure.ResourceManager.Compute/src/Generated/Extensions/MockableComputeResourceGroupResource.cs | Updates default API version documentation for several resource-group convenience methods. |
| sdk/compute/Azure.ResourceManager.Compute/src/Generated/Extensions/ComputeExtensions.cs | Adds tenant-level shared gallery invite accept/reject extension methods (and helper to get mockable tenant resource). |
| sdk/compute/Azure.ResourceManager.Compute/src/Generated/DiskRestorePointResource.cs | Bumps default disk restore point API version. |
| sdk/compute/Azure.ResourceManager.Compute/src/Generated/DiskRestorePointData.cs | Adds SnapshotAccessState to disk restore point data surface. |
| sdk/compute/Azure.ResourceManager.Compute/src/Generated/DiskRestorePointCollection.cs | Bumps default disk restore point collection API version. |
| sdk/compute/Azure.ResourceManager.Compute/src/Generated/DiskEncryptionSetResource.cs | Bumps default disk encryption set API version. |
| sdk/compute/Azure.ResourceManager.Compute/src/Generated/DiskEncryptionSetCollection.cs | Bumps default disk encryption set collection API version. |
| sdk/compute/Azure.ResourceManager.Compute/src/Generated/DiskAccessResource.cs | Bumps default disk access API version. |
| sdk/compute/Azure.ResourceManager.Compute/src/Generated/DiskAccessCollection.cs | Bumps default disk access collection API version. |
| sdk/compute/Azure.ResourceManager.Compute/src/Generated/ComputePrivateEndpointConnectionResource.cs | Bumps default private endpoint connection API version. |
| sdk/compute/Azure.ResourceManager.Compute/src/Generated/ComputePrivateEndpointConnectionCollection.cs | Bumps default private endpoint connection collection API version. |
| sdk/compute/Azure.ResourceManager.Compute/src/Generated/ArmComputeModelFactory.cs | Updates model factory overloads to include newly generated properties/models. |
| sdk/compute/Azure.ResourceManager.Compute/src/Azure.ResourceManager.Compute.csproj | Promotes package version from prerelease to stable 1.15.0. |
| sdk/compute/Azure.ResourceManager.Compute/metadata.json | Updates tracked API versions (ComputeDisk, ComputeGallery). |
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
There was a problem hiding this comment.
Management SDK Review Summary
- Scope:
Azure.ResourceManager.Compute(1.14.0 → 1.15.0) - Versioning: ❌ FAIL — CHANGELOG not updated for stable release (see inline)
- API surface:
⚠️ 2 scanner warnings (SUFFIX006), 0 errors - Contextual naming: evaluated 36 new public types, flagged 3 (non-blocking)
- ApiCompat / breaking changes: ⏳ PENDING — CI checks still in progress
- Migration-specific checks: N/A
Phase 1 — Versioning (BLOCKING)
The .csproj version was promoted from 1.15.0-beta.2 to 1.15.0 (stable) but CHANGELOG.md was not updated. The current top-of-changelog entry is ## 1.15.0-beta.2 (Unreleased) with empty sections. A proper ## 1.15.0 (date) entry documenting all features added since 1.14.0 is required before release.
Phase 2 — API Surface
Scanner (with 1.14.0 baseline): 0 errors, 2 warnings:
ImmutabilityPolicyData— [SUFFIX006] should beImmutabilityPolicyContent(inline comment attached)ImmutabilityPolicyLockData— [SUFFIX006] should beImmutabilityPolicyLockContent(inline comment attached)
Both are generated types; fix via TypeSpec @@clientName`` in client.tsp.
Non-inline findings — Contextual naming (non-blocking suggestions):
The following new types (added relative to 1.14.0 stable, but not changed in this PR's diff) have names that are ambiguous without namespace context. Consider adding RP-specific prefixes via TypeSpec @@clientName``:
| Type | Concern | Suggested name |
|---|---|---|
ExternalHealthPolicy |
No RP/resource context | ComputeExternalHealthPolicy |
StorageAlignmentStatus |
"Storage" prefix conflicts with Azure.Storage.* SDK |
ComputeStorageAlignmentStatus |
StorageFaultDomainAlignmentType |
Same "Storage" prefix concern | ComputeStorageFaultDomainAlignmentType |
Phase 3 — Breaking Changes
CI checks (net - pullrequest, Build matrices) are still in_progress/queued. ApiCompat runs during dotnet pack; results are not yet available. ApiCompatVersion=1.14.0 is correctly set and present. No ApiCompat suppression entries were added. Full breaking-change verdict pending CI completion.
3 inline comments | Analyzed by azure-sdk-mgmt-pr-review:
Analyzed by Azure .NET Management SDK PR Review: https://github.com/Azure/azure-sdk-for-net/actions/runs/28141233164
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
There was a problem hiding this comment.
Management SDK Review Summary
- Scope:
Azure.ResourceManager.Compute(1.14.0 → 1.15.0) - Versioning: ✅ PASS — version promoted to stable
1.15.0;CHANGELOG.mdupdated with feature descriptions;ApiCompatVersion=1.14.0retained - API surface: ✅ PASS — 0 scanner violations (183 baseline violations filtered); all prior findings resolved
- Contextual naming: evaluated 36 new public types, flagged 0
- ApiCompat / breaking changes: ⏳ PENDING — CI checks still
in_progress/queued;ApiCompatVersion=1.14.0is correctly set and no new baseline suppression entries were added - Migration-specific checks: N/A
All blocking findings from the previous review have been addressed:
- CHANGELOG: The
## 1.15.0 (Unreleased)entry now contains a full features-added description covering API version upgrades, snapshot immutability policy, shared gallery invite accept/reject,ConfidentialVmVersion, and all VMSS additions. ✅ - SUFFIX006:
ImmutabilityPolicyData→ImmutabilityPolicyContentandImmutabilityPolicyLockData→ImmutabilityPolicyLockContent. ✅ - Contextual naming:
ExternalHealthPolicy→ComputeExternalHealthPolicy,StorageAlignmentStatus→ComputeStorageAlignmentStatus,StorageFaultDomainAlignmentType→ComputeStorageFaultDomainAlignmentType. ✅
Non-blocking optional suggestion — ImmutabilityPolicy* family
The four new Snapshot-immutability types (ImmutabilityPolicy, ImmutabilityPolicyContent, ImmutabilityPolicyLockContent, ImmutabilityPolicyType) have no resource-level prefix distinguishing them as Compute Snapshot types. Azure Storage, for example, uses BlobImmutabilityPolicy. A Snapshot prefix (e.g., SnapshotImmutabilityPolicy) would reduce ambiguity in IntelliSense across multi-RP projects. This is a low-priority suggestion only — no action required before merge.
No inline review comments. 0 blocking findings. Full breaking-change verdict requires CI completion (ApiCompat runs during dotnet pack).
Analyzed by Azure .NET Management SDK PR Review: https://github.com/Azure/azure-sdk-for-net/actions/runs/28149556825
Analyzed by Azure .NET Management SDK PR Review: https://github.com/Azure/azure-sdk-for-net/actions/runs/28149556825
github-actions
Bot
dismissed
their stale review
Dismissed because Azure .NET Management SDK PR Review found no blocking issues on newer commit 15558f2.
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
There was a problem hiding this comment.
Management SDK Review Summary
Same status as the previous management SDK review: no blocking management SDK review findings on Azure.ResourceManager.Compute 1.15.0. No new management SDK review findings on this head commit.
The two commits added after the previous review (86784fc9 and deacd2cf) removed and re-generated the same source code — the API surface file is byte-for-byte identical to the previously reviewed commit (15558f25). Scanner: 0 violations (183 baseline violations filtered); contextual naming: 36 new public types, 0 flagged.
Note (carry-forward from previous review): tsp-location.yaml still references ArcturusZhang/azure-rest-api-specs rather than the canonical Azure/azure-rest-api-specs. Before merge, ensure the spec changes have been merged to the canonical repository and tsp-location.yaml is updated accordingly.
CI: net - pullrequest checks are still in_progress/queued; ApiCompat verdict remains pending.
Analyzed by Azure .NET Management SDK PR Review: https://github.com/Azure/azure-sdk-for-net/actions/runs/28151145630
Analyzed by Azure .NET Management SDK PR Review: https://github.com/Azure/azure-sdk-for-net/actions/runs/28151145630
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
There was a problem hiding this comment.
Management SDK Review Summary
Skipped full management SDK review because only low-risk files changed since the previous no-finding management review. No new management SDK review findings.
Carry-forward note: tsp-location.yaml still references ArcturusZhang/azure-rest-api-specs (commit SHA updated to 9d5f8b8d4b31057b3de09e9408c70f3ee07f70fc). Before merge, ensure the spec changes have been merged to the canonical Azure/azure-rest-api-specs repository and tsp-location.yaml is updated accordingly.
CI: net - pullrequest checks are still in_progress/queued; ApiCompat verdict remains pending.
Analyzed by Azure .NET Management SDK PR Review: https://github.com/Azure/azure-sdk-for-net/actions/runs/28152825648
Analyzed by Azure .NET Management SDK PR Review: https://github.com/Azure/azure-sdk-for-net/actions/runs/28152825648
Configurations: 'specification/compute/resource-manager/Microsoft.Compute/Compute/tspconfig.yaml', SDK Release Type: stable, and CommitSHA: 'f1afa57769d1e6267fb93258cf23229efc7edd0f' in SpecRepo: 'https://github.com/Azure/azure-rest-api-specs' Pipeline run: https://dev.azure.com/azure-sdk/internal/_build/results?buildId=6479802 Refer to https://eng.ms/docs/products/azure-developer-experience/develop/sdk-release/sdk-release-prerequisites to prepare for SDK release. Release plan link: https://azsdk-releaseplan-dashboard-hveph5aqhhcfhtgu.westus-01.azurewebsites.net/?releaseplan=35010 Submitted by: audreytoney@microsoft.com