Skip to content

[AutoPR Azure.ResourceManager.MongoCluster]-generated-from-SDK Generation - .NET-6477224#60194

Merged
sachim merged 2 commits into
mainfrom
sdkauto/Azure.ResourceManager.MongoCluster-6477224
Jun 26, 2026
Merged

[AutoPR Azure.ResourceManager.MongoCluster]-generated-from-SDK Generation - .NET-6477224#60194
sachim merged 2 commits into
mainfrom
sdkauto/Azure.ResourceManager.MongoCluster-6477224

Conversation

@azure-sdk

Copy link
Copy Markdown
Collaborator

Configurations: 'specification/mongocluster/resource-manager/Microsoft.DocumentDB/MongoCluster/tspconfig.yaml', API Version: 2026-06-01, SDK Release Type: stable, and CommitSHA: 'ac5f7d96bc313f0d1df718dffe02a85a5ddff6b8' in SpecRepo: 'https://github.com/Azure/azure-rest-api-specs' Pipeline run: https://dev.azure.com/azure-sdk/internal/_build/results?buildId=6477224 Refer to https://eng.ms/docs/products/azure-developer-experience/develop/sdk-release/sdk-release-prerequisites to prepare for SDK release. Release plan link: https://azsdk-releaseplan-dashboard-hveph5aqhhcfhtgu.westus-01.azurewebsites.net/?releaseplan=2214 Submitted by: olivert@microsoft.com

…t.DocumentDB/MongoCluster/tspconfig.yaml', API Version: 2026-06-01, SDK Release Type: stable, and CommitSHA: 'ac5f7d96bc313f0d1df718dffe02a85a5ddff6b8' in SpecRepo: 'https://github.com/Azure/azure-rest-api-specs' Pipeline run: https://dev.azure.com/azure-sdk/internal/_build/results?buildId=6477224 Refer to https://eng.ms/docs/products/azure-developer-experience/develop/sdk-release/sdk-release-prerequisites to prepare for SDK release.
Copilot AI review requested due to automatic review settings June 24, 2026 15:27
@github-actions github-actions Bot added the Mgmt This issue is related to a management-plane library. label Jun 24, 2026

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR updates the Azure.ResourceManager.MongoCluster management-plane SDK to align with the 2026-06-01 stable ARM API version from azure-rest-api-specs and promotes the package version to a stable release.

Changes:

  • Updated the TypeSpec spec reference (tsp-location.yaml) to a newer azure-rest-api-specs commit.
  • Regenerated SDK code to use default API version 2026-06-01 (replacing 2026-02-01-preview) across resources/collections.
  • Promoted the NuGet package version from 1.1.0-beta.2 to 1.1.0 and updated metadata.json API version.

Reviewed changes

Copilot reviewed 3 out of 13 changed files in this pull request and generated 1 comment.

Show a summary per file
File Description
sdk/mongocluster/Azure.ResourceManager.MongoCluster/tsp-location.yaml Points generation at the updated spec commit and maintains TypeSpec location metadata.
sdk/mongocluster/Azure.ResourceManager.MongoCluster/src/Generated/MongoClusterUserResource.cs Updates default API version used by the generated Users REST client and docs.
sdk/mongocluster/Azure.ResourceManager.MongoCluster/src/Generated/MongoClusterUserCollection.cs Updates default API version used by the generated Users REST client and docs.
sdk/mongocluster/Azure.ResourceManager.MongoCluster/src/Generated/MongoClusterResource.cs Updates default API version used by MongoClusters/PrivateLinks/Replicas REST clients and docs.
sdk/mongocluster/Azure.ResourceManager.MongoCluster/src/Generated/MongoClusterPrivateEndpointConnectionResourceCollection.cs Updates default API version for PrivateEndpointConnections operations and docs.
sdk/mongocluster/Azure.ResourceManager.MongoCluster/src/Generated/MongoClusterPrivateEndpointConnectionResource.cs Updates default API version for PrivateEndpointConnections operations and docs.
sdk/mongocluster/Azure.ResourceManager.MongoCluster/src/Generated/MongoClusterFirewallRuleResource.cs Updates default API version for FirewallRules operations and docs.
sdk/mongocluster/Azure.ResourceManager.MongoCluster/src/Generated/MongoClusterFirewallRuleCollection.cs Updates default API version for FirewallRules operations and docs.
sdk/mongocluster/Azure.ResourceManager.MongoCluster/src/Generated/MongoClusterCollection.cs Updates default API version for MongoClusters collection operations and docs.
sdk/mongocluster/Azure.ResourceManager.MongoCluster/src/Generated/Extensions/MockableMongoClusterSubscriptionResource.cs Updates mockable extension REST client default API version and docs.
sdk/mongocluster/Azure.ResourceManager.MongoCluster/src/Generated/Extensions/MockableMongoClusterResourceGroupResource.cs Updates mockable extension docs to reflect the new default API version.
sdk/mongocluster/Azure.ResourceManager.MongoCluster/src/Azure.ResourceManager.MongoCluster.csproj Promotes package version to stable 1.1.0.
sdk/mongocluster/Azure.ResourceManager.MongoCluster/metadata.json Updates tracked RP API version to 2026-06-01.

@sachim sachim requested a review from olivertowers June 24, 2026 16:09

@github-actions github-actions Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Management SDK Review Summary

  • Scope: Azure.ResourceManager.MongoCluster
  • Versioning: ✅ pass
  • API surface: ✅ pass — no naming violations
  • Contextual naming: evaluated 1 new public type, flagged 0
  • ApiCompat / breaking changes: ✅ pass (from API diff; CI still in progress)
  • Migration-specific checks: N/A

Phase 1 — Versioning

All checks pass:

  • Version promoted from 1.1.0-beta.21.1.0 ✅ (appropriate stable minor release over GA baseline 1.0.0)
  • ApiCompatVersion=1.0.0 is present and correctly points to the last stable GA release ✅
  • CHANGELOG.md has a well-formed ## 1.1.0 (2026-06-24) entry listing all features added ✅

Phase 2 — API Review

Deterministic scanner: No naming violations found (5 baseline violations filtered — all pre-existing).

Contextual naming (1 new public type):

Type Kind Verdict
MongoClusterNetworkBypassMode struct (extensible enum) ✅ OK — MongoCluster prefix gives full RP context; NetworkBypassMode is a clear domain concept; members AzureCosmosDB and None are well-named

Other API additions relative to 1.0.0 baseline:

  • New NetworkBypassMode? property on MongoClusterProperties and MongoClusterUpdateProperties
  • New MongoClusterAuthenticationMode.MicrosoftEntraID member ✅
  • MongoClusterEntraIdentityProvider.MongoClusterEntraIdentityProviderPrincipalType marked [Obsolete("This property has been renamed to PrincipalType.")] with new PrincipalType property — correct migration shim pattern ✅
  • Protected virtual JsonModelCreateCore / PersistableModelCreateCore / PersistableModelWriteCore added to many types — generated serialization infrastructure improvements ✅
  • implicit operator T? operators promoted from [EditorBrowsable(Never)] to fully public across several structs — additive, non-breaking ✅
  • New factory methods added to ArmMongoClusterModelFactory for many existing models — improves testability ✅

Phase 3 — Breaking Changes

API diff against 1.0.0 baseline shows no removals of public API surface. The only changes to the 1.0.0 baseline that touch existing members are:

  • [EditorBrowsable(Never)] removal from implicit nullable operators — surfaces previously hidden public members, not binary-breaking ✅
  • MongoClusterEntraIdentityProviderPrincipalType decorated with [Obsolete] but still present — not breaking ✅

CI checks are in progress at review time. No completed check reported failure (SDLSources ✅). No ApiCompat errors surfaced.

No management SDK review blocking issues found.


Analyzed by azure-sdk-mgmt-pr-review: PR #60194 @ c0e2ddbc

Analyzed by Azure .NET Management SDK PR Review: https://github.com/Azure/azure-sdk-for-net/actions/runs/28113527633

@olivertowers olivertowers left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@sachim sachim merged commit a806d1d into main Jun 26, 2026
29 checks passed
@sachim sachim deleted the sdkauto/Azure.ResourceManager.MongoCluster-6477224 branch June 26, 2026 02:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Mgmt This issue is related to a management-plane library.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants