Add DefaultDependencies=no back for Linux GPA service#272
Conversation
There was a problem hiding this comment.
Pull Request Overview
This PR adds the DefaultDependencies=no directive back to the Linux Azure Proxy Agent systemd service configuration. This change ensures the service behaves as an early boot and late system shutdown service by removing default systemd dependencies.
- Restores
DefaultDependencies=noconfiguration with explanatory comment
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
|
I don't think you can comment like this in a unit file. Here is the error I got when trying to test this change: |
|
Otherwise, I tested the change without the comment and it seems to fix the issue we were seeing on Ubuntu 24.04 LTS. |
Thanks for it, I fixed and tested it now. |
@gjolly , could you please help review and test it again with the new updates? |
@ZhidongPeng See #272 (comment) . |
* Remove backtrace crate as it has perf concern. (#273) * Add feature switch to collect the http connection proxy trace details (#274) * Add feature switch to collect the http connection proxy trace details * add comments for enableHtpProxyTrace config * correct trace level * rename folder rpmbuild to rpm-build for internal rpm packaging only. (#277) Co-authored-by: Zhidong Peng <zpeng@micrsoft.com> * Quick fix from Linux RPM Spec work. (#278) * Quick fix from Linux RPM Spec work. * install component clippy for lint jobs --------- Co-authored-by: Zhidong Peng <zpeng@micrsoft.com> * redact the secrets for the process command line (#280) * redact the secrets in the command line * quick return if input text is empty * fix build warnings * update path --------- Co-authored-by: Zhidong Peng <zpeng@micrsoft.com> * Add `DefaultDependencies=no` back for Linux GPA service (#272) * add DefaultDependencies=no for Linux GPA service * Fix the comment * add Baseline init + clean shutdown * fix spelling * fix the dependency --------- Co-authored-by: Zhidong Peng <zpeng@micrsoft.com> * remove crate dependency 'uuid'-'macro-diagnostics' (#281) Co-authored-by: Zhidong Peng <zpeng@micrsoft.com> * Move hyper_client & host_clients into shared crate (#282) * remove crate dependency 'uuid'-'macro-diagnostics' * Move hyper_client into shared crate * fix * Move host_clients into shared crate. * clean test * fix --------- Co-authored-by: Zhidong Peng <zpeng@micrsoft.com> * Fix azure-proxy-agent --status --wait xx fails to wait during eBPF still restarting (#287) * Fix azure-proxy-agent --status --wait xx fails to wait during eBPF redirector is starting * fix formatting. * update comment * rename constants::TIME_TICK_HEADER --------- Co-authored-by: Zhidong Peng <zpeng@micrsoft.com> * Replace hmac_sha256 with native crypto crates (#284) * add openssl for hmac_sha256 * move openssl for linux only * remove hmac_256 for windows too * fix build error * use vendored openssl for iinux musl target * fix * add pkg-config just in case for devbox --------- Co-authored-by: Zhidong Peng <zpeng@micrsoft.com> * Fix $PIRExtensionFolderZIPLocation value in e2etest InstallGuestProxyAgentExtension.ps1 (#288) * Prepare build for 1.0.37 release * Fix cmp_owned clippy error from rustc 1.91.0 (#290) * Fix cmp_owned clippy error from rustc 1.91.0 * update from copilot review --------- Co-authored-by: Zhidong Peng <zpeng@micrsoft.com> --------- Co-authored-by: Zhidong Peng <zpeng@micrsoft.com>
No description provided.