This repository was archived by the owner on Jun 11, 2026. It is now read-only.
Add a custom role for accessing batch account#20
Draft
sushilkm wants to merge 3 commits into
Draft
Conversation
mandarinamdar
left a comment
mandarinamdar
left a comment
Member
There was a problem hiding this comment.
If we dont need a contributor role now, we need to update that in README too
Contributor
Author
Done. |
karthick-rn
approved these changes
May 4, 2022
|
|
||
| Note: The Bicep template adds the Synapse workspace's Managed Identity to the Batch Account as `Contributor`. Alternatively, Custom Role Definitions can be used to assign the Synapse workspace's Managed Identity to the Batch Account with required Azure RBAC operations. | ||
|
|
||
| Note: The Bicep template adds the Synapse workspace's Managed Identity to the Batch Account with a Custom Role Access. |
Member
There was a problem hiding this comment.
I think adding a line to state the reason why we prefer Custom Role Access will be helpful.
Member
|
I haven't had the chance to test the PR, but overall the changes look good to me. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #23