Skip datasources sync for prow#5236
Conversation
There was a problem hiding this comment.
Pull request overview
This PR introduces an environment-configurable flag to skip Grafana datasource synchronization, and enables it by default for prow environments to avoid frequent 409s from concurrent updates.
Changes:
- Add a
SkipSyncshort-circuit to the Grafana datasources pipeline step. - Wire
monitoring.skipDatasourceSyncinto the region pipeline asskipSync. - Extend config defaults/schema and set prow rendered config to skip datasource sync.
Reviewed changes
Copilot reviewed 10 out of 10 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| tooling/templatize/pkg/pipeline/grafana_datasources.go | Adds early-return when SkipSync is set, with a log message. |
| dev-infrastructure/region-pipeline.yaml | Passes config-driven skipDatasourceSync into the GrafanaDatasources step as skipSync. |
| config/rendered/dev/prow/westus3.yaml | Enables skipDatasourceSync: true for prow. |
| config/rendered/dev/pers/westus3.yaml | Adds explicit skipDatasourceSync: false in rendered config. |
| config/rendered/dev/perf/westus3.yaml | Adds explicit skipDatasourceSync: false in rendered config. |
| config/rendered/dev/dev/westus3.yaml | Adds explicit skipDatasourceSync: false in rendered config. |
| config/rendered/dev/cspr/westus3.yaml | Adds explicit skipDatasourceSync: false in rendered config. |
| config/rendered/dev/ci01/westus3.yaml | Adds explicit skipDatasourceSync: false in rendered config. |
| config/config.yaml | Adds default monitoring.skipDatasourceSync: false and sets prow defaults to true. |
| config/config.schema.json | Extends the monitoring schema with skipDatasourceSync boolean. |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: janboll, raelga The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
New changes are detected. LGTM label has been removed. |
|
@janboll: The following tests failed, say
Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
What/Why
Add skipDatasourceSync to skip sync for certain environments.
Also add the skip for prow environments.
We commonly see 409 caused by concurrent updates