Skip to content

Skip datasources sync for prow#5236

Open
janboll wants to merge 4 commits into
mainfrom
prow-skip-datasources
Open

Skip datasources sync for prow#5236
janboll wants to merge 4 commits into
mainfrom
prow-skip-datasources

Conversation

@janboll
Copy link
Copy Markdown
Collaborator

@janboll janboll commented May 12, 2026

What/Why

Add skipDatasourceSync to skip sync for certain environments.
Also add the skip for prow environments.
We commonly see 409 caused by concurrent updates

Copilot AI review requested due to automatic review settings May 12, 2026 13:35
@openshift-ci openshift-ci Bot requested review from roivaz and sclarkso May 12, 2026 13:35
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR introduces an environment-configurable flag to skip Grafana datasource synchronization, and enables it by default for prow environments to avoid frequent 409s from concurrent updates.

Changes:

  • Add a SkipSync short-circuit to the Grafana datasources pipeline step.
  • Wire monitoring.skipDatasourceSync into the region pipeline as skipSync.
  • Extend config defaults/schema and set prow rendered config to skip datasource sync.

Reviewed changes

Copilot reviewed 10 out of 10 changed files in this pull request and generated no comments.

Show a summary per file
File Description
tooling/templatize/pkg/pipeline/grafana_datasources.go Adds early-return when SkipSync is set, with a log message.
dev-infrastructure/region-pipeline.yaml Passes config-driven skipDatasourceSync into the GrafanaDatasources step as skipSync.
config/rendered/dev/prow/westus3.yaml Enables skipDatasourceSync: true for prow.
config/rendered/dev/pers/westus3.yaml Adds explicit skipDatasourceSync: false in rendered config.
config/rendered/dev/perf/westus3.yaml Adds explicit skipDatasourceSync: false in rendered config.
config/rendered/dev/dev/westus3.yaml Adds explicit skipDatasourceSync: false in rendered config.
config/rendered/dev/cspr/westus3.yaml Adds explicit skipDatasourceSync: false in rendered config.
config/rendered/dev/ci01/westus3.yaml Adds explicit skipDatasourceSync: false in rendered config.
config/config.yaml Adds default monitoring.skipDatasourceSync: false and sets prow defaults to true.
config/config.schema.json Extends the monitoring schema with skipDatasourceSync boolean.

Copilot AI review requested due to automatic review settings May 12, 2026 14:26
Comment thread config/config.yaml
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 18 out of 26 changed files in this pull request and generated no new comments.

Copy link
Copy Markdown
Collaborator

@raelga raelga left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@openshift-ci
Copy link
Copy Markdown

openshift-ci Bot commented May 13, 2026

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: janboll, raelga

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-bot
Copy link
Copy Markdown
Contributor

/retest-required

Remaining retests: 0 against base HEAD 6c7c554 and 2 for PR HEAD dd7e9f6 in total

Copilot AI review requested due to automatic review settings May 13, 2026 07:59
@openshift-ci openshift-ci Bot removed the lgtm label May 13, 2026
@openshift-ci
Copy link
Copy Markdown

openshift-ci Bot commented May 13, 2026

New changes are detected. LGTM label has been removed.

Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 18 out of 26 changed files in this pull request and generated no new comments.

@openshift-ci
Copy link
Copy Markdown

openshift-ci Bot commented May 13, 2026

@janboll: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/e2e-parallel 554a429 link true /test e2e-parallel
ci/prow/verify 1a5c6ff link true /test verify

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants