Add Conditions to our Resource Types#5214
Draft
bennerv wants to merge 2 commits into
Draft
Conversation
|
Skipping CI for Draft Pull Request. |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: bennerv The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Closed
Member
Author
|
missing examples, generating them. |
bennerv
force-pushed
the
bvesel/add-conditions-to-resource-types
branch
from
6c09730 to
8eec46d
Compare
The ExternalAuth Condition field is read-only (server-managed) and should not be converted from client input. Remove the conversion from ConvertToInternal in v20240610preview and v20251223preview, and zero the field in fuzz tests since it no longer round-trips. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Adds read-only conditions (following Kubernetes status.conditions conventions) to HCPOpenShiftCluster, NodePool, and ExternalAuth resource types under a new API version 2026-05-31-preview. Conditions use a generic Condition model with ConditionType union (Available, Degraded, Progressing) shared across all resource types. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
bennerv
force-pushed
the
bvesel/add-conditions-to-resource-types
branch
from
8eec46d to
82f951f
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Adds read only conditions to our resource types to expose status information to the customer
Why
Exposes status information to the customer.
Testing
Special notes for your reviewer
conditionfor externalAuth resource type, uses conditions insteadcondition(existing external auth) andconditions(new field)TODO