fix: resolve Event Grid MI delivery authorization failure#2277
Open
Vamshi-Microsoft wants to merge 4 commits into
Open
fix: resolve Event Grid MI delivery authorization failure#2277Vamshi-Microsoft wants to merge 4 commits into
Vamshi-Microsoft wants to merge 4 commits into
Conversation
…reamline role assignments in Bicep template
…ription Restructure the new-topic Event Grid path in main.bicep into a three-step vanilla-first pattern. declare the system topic as a plain resource with a system-assigned MI, grant it the Storage Queue Data Message Sender role at account scope, then configure the subscription via the AVM module with dependsOn on both — so the role exists before Event Grid's synchronous MI-delivery preflight runs
…structuring role assignment and subscription creation order
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose
This pull request makes a series of improvements to the
v2/infra/main.bicepfile, focusing on code readability, maintainability, and resource provisioning reliability. The main themes are: reformatting long lines for better readability, restructuring resource and variable assignments for clarity, and introducing a more reliable pattern for Event Grid system topic provisioning to avoid deployment race conditions.Key changes include:
Resource provisioning reliability:
Readability and maintainability improvements:
Reformatted long inline expressions and object initializations (such as conditional assignments and array/object definitions) to use multi-line, indented blocks for improved readability throughout the file. This includes variable assignments, module parameters, and environment variable definitions. [1] [2] [3] [4] [5] [6] [7] [8] [9]
Reformatted all
roleDefinitionIdassignments in resource role assignments to use multi-line calls tosubscriptionResourceId, improving consistency and making the code easier to scan and modify. [1] [2] [3] [4] [5] [6] [7] [8] [9]Environment variable and configuration improvements:
These changes collectively improve the reliability of infrastructure deployments and make the codebase easier to read and maintain.
Does this introduce a breaking change?
How to Test
What to Check
Verify that the following are valid
Other Information