fix: Refactor event grid topic configuration for simplified identity handling#2275
Open
Vamshi-Microsoft wants to merge 2 commits into
Open
fix: Refactor event grid topic configuration for simplified identity handling#2275Vamshi-Microsoft wants to merge 2 commits into
Vamshi-Microsoft wants to merge 2 commits into
Conversation
Removed deliveryWithResourceIdentity from the Event Grid → blob-events queue subscription and use a plain StorageQueue destination instead. Enable allowSharedKeyAccess on the storage account so Event Grid can deliver without MI authorization (which was failing with "Eventhub Managed Identity Authorization Error").
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose
This pull request refactors the
v2/infra/main.bicepfile to improve code readability and maintainability by consistently applying multi-line formatting to complex expressions and parameters, especially for conditional assignments and resource properties. It also comments out/deactivates certain Event Grid system topic role assignments and delivery identity settings, likely as part of a configuration or deployment change.Key changes include:
Code formatting and readability improvements:
Event Grid system topic and role assignment adjustments:
managedIdentitiesproperty and thedeliveryWithResourceIdentityblock in theeventGridSystemTopicmodule, switching to directdestinationconfiguration for Storage Queue delivery. This may reflect a change in authentication or deployment strategy. [1] [2]eventGridQueueSenderRoleresource assignment, possibly deactivating an explicit role assignment for the Event Grid system topic's managed identity.Consistent variable assignment style:
effectiveOpenAiEndpoint,effectiveSearchName,effectiveSearchEndpoint,effectiveStorageBlobEndpoint,effectiveCosmosName, andeffectiveCosmosEndpoint) to use a multi-line, ternary-style format for improved clarity. [1] [2] [3] [4]These changes do not alter the core logic or functionality but make the infrastructure codebase easier to read and maintain, and reflect some configuration changes around Event Grid integration.
Does this introduce a breaking change?
How to Test
What to Check
Verify that the following are valid
Other Information