Update storage acct creation to include storageInfrastructureEncyption property#2159
Update storage acct creation to include storageInfrastructureEncyption property#2159janmallo wants to merge 2 commits into
Conversation
pamelafox
left a comment
There was a problem hiding this comment.
@tonybaloney Could you review this one, since you've been working on porting this module to AVM? It looks like this does match the parameter for the avm module, which defaults to true?
https://github.com/Azure/bicep-registry-modules/blob/main/avm/res/storage/storage-account/main.bicep#L78C7-L78C38
|
@janmallo Could you agree to the CLA? See comment from bot above. |
|
Please use |
|
@microsoft-github-policy-service agree |
| } : { defaultAction: 'Deny' } | ||
|
|
||
| resource storage 'Microsoft.Storage/storageAccounts@2022-05-01' = { | ||
| var encryption = (storageInfrastructureEncryption == 'Enabled') ? { |
There was a problem hiding this comment.
If it's going to be mapped to this object anyway, would it be better to make it a boolean?
There was a problem hiding this comment.
I just looked up the avm module, which we'll eventually move to, and it uses a boolean:
https://github.com/Azure/bicep-registry-modules/tree/main/avm/res/storage/storage-account#parameter-requireinfrastructureencryption
Purpose
Update storage acct creation to include storageInfrastructureEncyption property
Does this introduce a breaking change?
When developers merge from main and run the server, azd up, or azd deploy, will this produce an error?
If you're not sure, try it out on an old environment.
Does this require changes to learn.microsoft.com docs?
This repository is referenced by this tutorial
which includes deployment, settings and usage instructions. If text or screenshot need to change in the tutorial,
check the box below and notify the tutorial author. A Microsoft employee can do this for you if you're an external contributor.
Type of change
Code quality checklist
See CONTRIBUTING.md for more details.
python -m pytest).python -m pytest --covto verify 100% coverage of added linespython -m mypyto check for type errorsruffandblackmanually on my code.