Move Studio Code Desktop from feature flag to beta flag#3549
Draft
sejas wants to merge 1 commit into
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proposed Changes
enableStudioCodeUifrom the env-basedFEATURE_FLAGSregistry inapps/studio/src/lib/feature-flags.ts.enableStudioCodeUitoBetaFeaturesinapps/studio/src/ipc-types.d.tsand register it inapps/studio/src/lib/beta-features.ts(label: "Studio Code Desktop", default off).apps/studio/src/components/content-tab-assistant.tsxfromuseFeatureFlags()to a Redux selector readingstate.betaFeatures.features.enableStudioCodeUi.enableStudioCodeUi: falseand update the matching test fixtures incontent-tab-settings.test.tsx.The
ENABLE_STUDIO_CODE_UIenv var is no longer wired. Users now toggle Studio Code Desktop from the macOS app menu under WordPress Studio → Beta Features → Studio Code Desktop. The choice persists in~/.studio/app.jsonunderbetaFeatures.Testing Instructions
npm start.~/.studio/app.jsonunderbetaFeatures.enableStudioCodeUi).ENABLE_STUDIO_CODE_UI=true npm startno longer flips the UI (env var is intentionally removed).Pre-merge Checklist