Skip to content

PCIOS-732: iOS CarPlay: Apple Maps voice guidance repeatedly pauses playback (even when guidance volume is zero) #4520

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
pocketcasts wants to merge 1 commit into
base: trunk
Choose a base branch
from
+13 −1
Draft

PCIOS-732: iOS CarPlay: Apple Maps voice guidance repeatedly pauses playback (even when guidance volume is zero) #4520

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions Modules/Sources/PocketCastsUtils/Feature Flags/FeatureFlag.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -319,6 +319,9 @@ public enum FeatureFlag: String, CaseIterable {
/// Enable the Share Profile feature
case shareProfile

/// Rewind ~1s on auto-resume after an audio interruption (e.g. CarPlay nav prompts)
case rewindOnResumeAfterInterruption

public var enabled: Bool {
if let overriddenValue = FeatureFlagOverrideStore().overriddenValue(for: self) {
return overriddenValue
Expand Down Expand Up @@ -535,6 +538,8 @@ public enum FeatureFlag: String, CaseIterable {
false
case .shareProfile:
BuildEnvironment.current == .debug
case .rewindOnResumeAfterInterruption:
true
}
}

Expand Down
9 changes: 8 additions & 1 deletion podcasts/PlaybackManager.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2104,7 +2104,14 @@ class PlaybackManager: ServerPlaybackDelegate {
let interruptionOption = userInfo[AVAudioSessionInterruptionOptionKey] as! NSNumber
FileLog.shared.addMessage("PlaybackManager handleAudioInterrupt ended, should attempt to restart audio: \(interruptionOption) reason: \(interruptionReason?.description ?? "unknown")")
if interruptionOption.uintValue == AVAudioSession.InterruptionOptions.shouldResume.rawValue, wasPlayingBeforeInterruption {
play(userInitiated: false)
if FeatureFlag.rewindOnResumeAfterInterruption.enabled {
let rewindInterval: TimeInterval = 1.0
let resumeTime = max(0, currentTime() - rewindInterval)
FileLog.shared.addMessage("PlaybackManager rewinding \(rewindInterval)s before resuming after interruption (from \(currentTime()) to \(resumeTime))")
seekTo(time: resumeTime, startPlaybackAfterSeek: true)
} else {
play(userInitiated: false)
}
wasPlayingBeforeInterruption = false
}
} else if interruptionType.uintValue == AVAudioSession.InterruptionType.began.rawValue {
Expand Down