feat: merged German diagnostics#3403
Closed
Dronakurl wants to merge 9 commits into
Closed
Conversation
Revert the change that requested two configuration sections (harper-ls and None), which caused the second config to overwrite the first. The update_config_from_obj() replaces the entire config, so processing both results in the second (empty or partial) config wiping out the first. The config.rs changes already handle both wrapped and unwrapped LSP configuration formats via Config::from_lsp_config(). Generated by Mistral Vibe. Co-Authored-By: Mistral Vibe <vibe@mistral.ai>
Includes: - German dictionary (compressed .dict.gz) - German parser (PlainGerman) - German linters (noun capitalization, sentence capitalization, spell check) - German Weir rules (25 rules) - Language detection registry - Integration tests for German support - Diagnostic delay fix for pull_config Generated by Mistral Vibe. Co-Authored-By: Mistral Vibe <vibe@mistral.ai>
…ranch This commit applies the clean-up changes from feature/diagnostics-in-normal-mode (commit 11bf93d) to the feature/merged-german-diagnostics branch, which combines both German language support and the diagnostics timing feature. Changes: - Add PendingDiagnosticTask type alias - Add last_change_generation field for generation-based tracking - Add publish_diagnostics_immediately method for instant feedback on code actions - Add HarperRecordLintAndUpdate command - Update code actions to use immediate diagnostics for dictionary updates - Use generation-based tracking instead of timestamp-based for delayed diagnostics Generated by Mistral Vibe. Co-Authored-By: Mistral Vibe <vibe@mistral.ai>
The german_weir_rules/mod.rs was directly trying to add WeirLinter as a chunk_expr_linter, but WeirLinter doesn't implement ExprLinter directly. Fixed by using the same pattern as weir_rules/mod.rs: convert to sentence_linter or chunk_linter first. Generated by Mistral Vibe. Co-Authored-By: Mistral Vibe <vibe@mistral.ai>
Collaborator
What's the relationship between this PR and #3402 |
The german_weir_rules module was not being registered in the main lint_group(), so the German weir rules were not being loaded. Generated by Mistral Vibe. Co-Authored-By: Mistral Vibe <vibe@mistral.ai>
From lint_group/mod.rs, the german_weir_rules module is accessed via super::german_weir_rules since both are sibling modules under linting/. Generated by Mistral Vibe. Co-Authored-By: Mistral Vibe <vibe@mistral.ai>
Contributor
Author
|
Sorry, that was a mistake, please ignore |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Merge German language support with diagnostic delay feature:
This branch combines both feature branches for production deployment.
Generated by Mistral Vibe.
Co-Authored-By: Mistral Vibe vibe@mistral.ai