Remove retired bfb/bac test residue from php-transformer#256
Merged
Conversation
block-format-bridge and block-artifact-compiler are retired packages, so the migration-example smoke branches and the opt-in legacy-comparison maps that pointed at them are dead: the legacy harness can never run against packages that no longer exist. - tests/migration/examples.php: drop the block-format-bridge-wrapper.php and block-artifact-compiler-wrapper.php smoke branches. The test still lints every globbed example and smoke-calls the live html-to-blocks and SSI adapter examples. - tests/parity/run.php: drop the format_bridge.normalize / artifact_compiler.compile entries (and the bfb_/bac_ callables and retired-repo bootstraps) from legacyRepoForOperation, legacyCallableForOperation, and legacyBootstrapForRepo. The current artifact_compiler.compile and format_bridge.normalize parity fixtures still run against the in-repo ArtifactCompiler/FormatBridge; only the external legacy-package comparison path is removed. No php-transformer-parity-fixture.schema.json exists and no JSON schema carries a module enum with the retired values, so there was no schema residue to remove. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Removes the remaining retired block-format-bridge (bfb) / block-artifact-compiler (bac) dead references from the php-transformer test surface. Complements #234 (which retires the bfb/bac consumer-PR docs); together they finish removing bfb/bac from the package.
Changes
tests/migration/examples.php— removed the two dead smoke branches for the retiredblock-format-bridge-wrapper.php/block-artifact-compiler-wrapper.phpexamples (thebfb_*/bac_*assertions). The test still globs+lints every example file and smoke-calls the live html-to-blocks-converter and static-site-importer adapter examples.tests/parity/run.php— removed the retired entries from the threeBLOCKS_ENGINE_PARITY_LEGACYcomparison maps (legacyRepoForOperation,legacyCallableForOperation,legacyBootstrapForRepo). Only the external legacy-package comparison path was removed — it could never run since the packages are gone. The 26 liveartifact_compiler.compile+ 1format_bridge.normalizefixtures exercise the in-reposrc/ArtifactCompiler/src/FormatBridgeand are unaffected.Verification
composer test+composer parity→ 128 fixtures green;test:migration:examplesand the opt-intest:migration:legacy-parityboth pass (legacy comparisons skip gracefully).vendor+ the out-of-scopedocs/consumer-prs/) → zeroblock-format-bridge/block-artifact-compiler/bfb_/bac_matches.AI assistance