Integration tests and Refactoring#1
Open
helena-donaldson wants to merge 10 commits into
Open
Conversation
rhit-fruechss
requested changes
Apr 8, 2026
rhit-fruechss
left a comment
rhit-fruechss
left a comment
Collaborator
There was a problem hiding this comment.
Mostly good - the README for the tests is especially welcome. There are just a couple of minor maintainability issues.
| import unittest | ||
| import zipfile | ||
|
|
||
| sys.path.insert(0, os.path.abspath(os.path.join(os.path.dirname(__file__), '../..'))) |
Collaborator
There was a problem hiding this comment.
This line should either be split into multiple lines or have a comment pointing out that it imports the GLADOS CLI.
| os.remove(f) | ||
|
|
||
| print("Starting experiment creation test...\n") | ||
| try: |
Collaborator
There was a problem hiding this comment.
There is some duplicated code here - see if you can use a helper function to centralize the try-except behavior as well as the output.
There was a problem hiding this comment.
Reduced redundances with added input/output functions
rhit-fruechss
approved these changes
May 22, 2026
rhit-fruechss
left a comment
rhit-fruechss
left a comment
Collaborator
There was a problem hiding this comment.
That all looks good - approving
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR includes the following: