Skip to content

AAA-251 remove groups/services from app_metadata, update them to match backend API#52

Merged
marius-mather merged 8 commits into
testfrom
remove-app-metadata
Sep 19, 2025
Merged

AAA-251 remove groups/services from app_metadata, update them to match backend API#52
marius-mather merged 8 commits into
testfrom
remove-app-metadata

Conversation

@marius-mather

@marius-mather marius-mather commented Sep 19, 2025

Copy link
Copy Markdown
Collaborator

Description

AAI-251: AustralianBioCommons/aai-backend#71 updates the backend to remove groups/services from app_metadata and instead query them from the database. This PR updates the frontend to match

Changes

  • Update platform/group APIs to match backend
  • Slight renaming of API functions to distinguish between user and admin endpoints
  • Update tests to work with updated APIs

Checklist

  • I have commented my code, particularly in hard-to-understand areas
  • I have added unit / integration tests that prove my fix is effective or that my feature works
  • I have run all tests locally and they pass
  • I have updated the documentation (if applicable)

How to Test Manually

Run npm run test

@marius-mather marius-mather marked this pull request as ready for review September 19, 2025 05:07

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR updates the frontend to align with backend API changes that remove groups/services from app_metadata and instead query them directly from the database. The changes rename API functions to distinguish between user and admin endpoints and update all components and tests to work with the new API structure.

  • Replaces services/resources API endpoints with platforms/groups endpoints
  • Renames API functions to use getUser* and getAdmin* prefixes for clarity
  • Updates data models and component templates to reflect the new structure

Reviewed Changes

Copilot reviewed 25 out of 25 changed files in this pull request and generated no comments.

Show a summary per file
File Description
services.component.ts Updates from services to platforms API with new data model
services.component.spec.ts Updates tests to use new platform endpoints and test data
services.component.html Changes template to display platform names using lookup constants
pending.component.ts Refactors to use new pending API structure with platforms and groups
pending.component.spec.ts Updates all tests to use new API endpoints and data models
access.component.ts Changes from resources to groups API endpoint
access.component.spec.ts Updates tests for groups instead of resources
access.component.html Updates template to display group information
revoked.component.ts Changes to admin-prefixed API endpoint and new user response type
revoked.component.spec.ts Updates tests with new API method and simplified user data
revoked.component.html Updates template to use new user ID field
requests.component.ts Changes to admin-prefixed API endpoint
requests.component.spec.ts Updates tests with new API method name
requests.component.html Updates template to use new user ID field
list-users.component.spec.ts Adds missing email_verified field to test data
list-unverified-users.component.ts Changes to admin-prefixed API endpoint
list-unverified-users.component.spec.ts Updates tests with new API method and user data structure
list-unverified-users.component.html Updates template to use new user ID field
navbar.component.ts Updates pending count calculation for new API structure
navbar.component.spec.ts Updates tests to use new API endpoints and data models
default-layout.component.spec.ts Updates mock API service calls to new endpoint names
auth.service.ts Removes unused interfaces that are now in api.service.ts
api.service.ts Adds new interfaces and updates all API methods to match backend
api.service.spec.ts Updates all API tests to use new endpoints and data structures
constants.ts Adds platform ID types and name mappings for display

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

@minh-biocommons minh-biocommons left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a tiny nitpick on 1 comment, but otherwise really good work syncing things to just platforms & groups like the back-end. Looks all good to me!

Comment thread src/app/layouts/navbar/navbar.component.ts Outdated
@marius-mather marius-mather merged commit 95a32e5 into test Sep 19, 2025
7 checks passed
@marius-mather marius-mather deleted the remove-app-metadata branch September 19, 2025 06:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants