AAA-251 remove groups/services from app_metadata, update them to match backend API#52
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR updates the frontend to align with backend API changes that remove groups/services from app_metadata and instead query them directly from the database. The changes rename API functions to distinguish between user and admin endpoints and update all components and tests to work with the new API structure.
- Replaces services/resources API endpoints with platforms/groups endpoints
- Renames API functions to use
getUser*andgetAdmin*prefixes for clarity - Updates data models and component templates to reflect the new structure
Reviewed Changes
Copilot reviewed 25 out of 25 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| services.component.ts | Updates from services to platforms API with new data model |
| services.component.spec.ts | Updates tests to use new platform endpoints and test data |
| services.component.html | Changes template to display platform names using lookup constants |
| pending.component.ts | Refactors to use new pending API structure with platforms and groups |
| pending.component.spec.ts | Updates all tests to use new API endpoints and data models |
| access.component.ts | Changes from resources to groups API endpoint |
| access.component.spec.ts | Updates tests for groups instead of resources |
| access.component.html | Updates template to display group information |
| revoked.component.ts | Changes to admin-prefixed API endpoint and new user response type |
| revoked.component.spec.ts | Updates tests with new API method and simplified user data |
| revoked.component.html | Updates template to use new user ID field |
| requests.component.ts | Changes to admin-prefixed API endpoint |
| requests.component.spec.ts | Updates tests with new API method name |
| requests.component.html | Updates template to use new user ID field |
| list-users.component.spec.ts | Adds missing email_verified field to test data |
| list-unverified-users.component.ts | Changes to admin-prefixed API endpoint |
| list-unverified-users.component.spec.ts | Updates tests with new API method and user data structure |
| list-unverified-users.component.html | Updates template to use new user ID field |
| navbar.component.ts | Updates pending count calculation for new API structure |
| navbar.component.spec.ts | Updates tests to use new API endpoints and data models |
| default-layout.component.spec.ts | Updates mock API service calls to new endpoint names |
| auth.service.ts | Removes unused interfaces that are now in api.service.ts |
| api.service.ts | Adds new interfaces and updates all API methods to match backend |
| api.service.spec.ts | Updates all API tests to use new endpoints and data structures |
| constants.ts | Adds platform ID types and name mappings for display |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
minh-biocommons
previously approved these changes
Sep 19, 2025
minh-biocommons
left a comment
Collaborator
There was a problem hiding this comment.
Just a tiny nitpick on 1 comment, but otherwise really good work syncing things to just platforms & groups like the back-end. Looks all good to me!
minh-biocommons
approved these changes
Sep 19, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
AAI-251: AustralianBioCommons/aai-backend#71 updates the backend to remove groups/services from app_metadata and instead query them from the database. This PR updates the frontend to match
Changes
Checklist
How to Test Manually
Run
npm run test